From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS6Rg-0000EU-NQ for qemu-devel@nongnu.org; Fri, 04 Oct 2013 10:33:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VS6Ra-0004vQ-Bn for qemu-devel@nongnu.org; Fri, 04 Oct 2013 10:33:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS6Ra-0004vK-4T for qemu-devel@nongnu.org; Fri, 04 Oct 2013 10:33:26 -0400 Message-ID: <524ED1AF.8090505@redhat.com> Date: Fri, 04 Oct 2013 16:33:19 +0200 From: Max Reitz MIME-Version: 1.0 References: <1380717564-11098-1-git-send-email-benoit@irqsave.net> <1380717564-11098-2-git-send-email-benoit@irqsave.net> In-Reply-To: <1380717564-11098-2-git-send-email-benoit@irqsave.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V9 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 2013-10-02 14:39, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > block/Makefile.objs | 1 + > block/quorum.c | 54 ++++++++++++++++++++++++++++++++++++++++++++= +++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 block/quorum.c > > diff --git a/block/Makefile.objs b/block/Makefile.objs > index 3bb85b5..05a65c2 100644 > --- a/block/Makefile.objs > +++ b/block/Makefile.objs > @@ -3,6 +3,7 @@ block-obj-y +=3D qcow2.o qcow2-refcount.o qcow2-cluster= .o qcow2-snapshot.o qcow2-c > block-obj-y +=3D qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-clu= ster.o > block-obj-y +=3D qed-check.o > block-obj-y +=3D vhdx.o > +block-obj-y +=3D quorum.o > block-obj-y +=3D parallels.o blkdebug.o blkverify.o > block-obj-y +=3D snapshot.o qapi.o > block-obj-$(CONFIG_WIN32) +=3D raw-win32.o win32-aio.o > diff --git a/block/quorum.c b/block/quorum.c > new file mode 100644 > index 0000000..76a1fbb > --- /dev/null > +++ b/block/quorum.c > @@ -0,0 +1,54 @@ > +/* > + * Quorum Block filter > + * > + * Copyright (C) 2012-2013 Nodalink, SARL. > + * > + * Author: > + * Beno=C3=AEt Canet > + * > + * Based on the design and code of blkverify.c (Copyright (C) 2010 IBM= , Corp) > + * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc). > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or = later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include "block/block_int.h" > + > +typedef struct QuorumAIOCB QuorumAIOCB; > + > +/* Quorum will create one instance of the following structure per read= /write > + * operation it do on it's children. I'd vote for "operation it performs on its children" or something like th= at. Max > + * So for each read/write operation coming from the upper layer there = will be > + * $children_count QuorumSingleAIOCB. > + */ > +typedef struct QuorumSingleAIOCB { > + BlockDriverAIOCB *aiocb; > + QEMUIOVector qiov; > + uint8_t *buf; > + int ret; > + QuorumAIOCB *parent; > +} QuorumSingleAIOCB; > + > +/* Quorum will use the following structure to track progress of each r= ead/write > + * operation received by the upper layer. > + * This structure hold pointers to the QuorumSingleAIOCB structures in= stances > + * used to do operations on each children and track overall progress. > + */ > +struct QuorumAIOCB { > + BlockDriverAIOCB common; > + > + /* Request metadata */ > + uint64_t sector_num; > + int nb_sectors; > + > + QEMUIOVector *qiov; /* calling IOV */ > + > + QuorumSingleAIOCB *aios; /* individual AIOs */ > + int count; /* number of completed AIOCB */ > + int success_count; /* number of successfully completed AI= OCB */ > + bool *finished; /* completion signal for cancel */ > + > + bool is_read; > + int vote_ret; > +};