From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56850)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1VS70q-0004PK-2B
	for qemu-devel@nongnu.org; Fri, 04 Oct 2013 11:09:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1VS70l-00005R-MY
	for qemu-devel@nongnu.org; Fri, 04 Oct 2013 11:09:51 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:40707)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1VS70l-0008W0-E9
	for qemu-devel@nongnu.org; Fri, 04 Oct 2013 11:09:47 -0400
Message-ID: <524EDA30.1000707@msgid.tls.msk.ru>
Date: Fri, 04 Oct 2013 19:09:36 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1379408075-12685-1-git-send-email-famz@redhat.com>
	<20130926132625.GA26743@T430s.nay.redhat.com>
	<CAJSP0QVuvLnjT4V7QVCSk-Eh7BAUV9byyrU6ndhgdrLvCHAHTg@mail.gmail.com>
In-Reply-To: <CAJSP0QVuvLnjT4V7QVCSk-Eh7BAUV9byyrU6ndhgdrLvCHAHTg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v11 0/8] Shared Library Module Support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Alex Bligh <alex@alex.org.uk>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Llu=EDs_Vilanova?= <vilanova@ac.upc.edu>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Wayne Xia <xiawenc@linux.vnet.ibm.com>, Richard Henderson <rth@twiddle.net>

04.10.2013 18:48, Stefan Hajnoczi wrote:
> On Thu, Sep 26, 2013 at 3:26 PM, Fam Zheng <famz@redhat.com> wrote:
>> On Tue, 09/17 16:54, Fam Zheng wrote:
>>> This series implements feature of shared object building as described in:
>>>
>>> http://wiki.qemu.org/Features/Modules
>>>
>>> The main idea behind modules is to isolate dependencies on third party
>>> libraries from qemu executables, such as libglusterfs or librbd, so that the
>>> end users can install core qemu package with fewer dependencies.  And only for
>>> those who want to use particular modules, need they install qemu-foo
>>> sub-package, which in turn requires libbar and libbiz packages.
>>>
>>> It's implemented in three steps:
>>>
>>> 1. The first patches fix current build system to correctly handle nested
>>>    variables and object specific options:
>>>
>>>     [01/08] ui/Makefile.objs: delete unnecessary cocoa.o dependency
>>>     [02/08] make.rule: fix $(obj) to a real relative path
>>>     [03/08] rule.mak: allow per object cflags and libs
>>>
>>> 2. The Makefile changes adds necessary options and rules to build DSO objects:
>>>
>>>     [04/08] build-sys: introduce common-obj-m and block-obj-m for DSO
>>>
>>> 3. The next patch adds code to load modules from installed directory:
>>>
>>>     [05/08] module: implement module loading
>>>
>>> A few more changes are following to complete it:
>>>
>>>     [06/08] Makefile: install modules with "make install"
>>>     [07/08] .gitignore: ignore module related files (dll, so, mo)
>>>
>>> In the end of series, the block drivers are converted:
>>>
>>>     [08/08] block: convert block drivers linked with libs to modules

All the series:

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

Thank you for the good work!

/mjt