From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS7MN-0002uq-Cl for qemu-devel@nongnu.org; Fri, 04 Oct 2013 11:32:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VS7MI-0007mz-G0 for qemu-devel@nongnu.org; Fri, 04 Oct 2013 11:32:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS7MI-0007lu-7O for qemu-devel@nongnu.org; Fri, 04 Oct 2013 11:32:02 -0400 Message-ID: <524EDF6D.80906@redhat.com> Date: Fri, 04 Oct 2013 09:31:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1380717564-11098-1-git-send-email-benoit@irqsave.net> <1380717564-11098-12-git-send-email-benoit@irqsave.net> <524EDB51.40605@redhat.com> In-Reply-To: <524EDB51.40605@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DN1alxx09xrPrw9xN6sAEhgRnfdgGUkTU" Subject: Re: [Qemu-devel] [PATCH V9 11/11] quorum: Add quorum_open() and quorum_close(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: kwolf@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , stefanha@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DN1alxx09xrPrw9xN6sAEhgRnfdgGUkTU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/04/2013 09:14 AM, Max Reitz wrote: > On 2013-10-02 14:39, Beno=C3=AEt Canet wrote: >> Example of command line: >> -drive if=3Dvirtio,file.driver=3Dquorum,\ >> file.children.0.file.filename=3D1.qcow2,\ >> file.children.1.file.filename=3D2.qcow2,\ >> file.children.2.file.filename=3D3.qcow2,\ >> file.vote_threshold=3D3 >> >=20 > Third, wouldn't it be better to use children[i] instead of children.i > for addressing them on the command line? I guess, a QMP interface would= > represent them as an array, so using the standard array index notation > seems better to me. No, we already discussed this. file.child[0].file.filename=3D1.qcow2 requires shell quoting to avoid unintentional shell globbing; file.child.0.file.filename=3D1.qcow2 is just as legible and can still be reconstructed into an array under the hood, and has the benefit of not needing quoting to protect against shell globbing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --DN1alxx09xrPrw9xN6sAEhgRnfdgGUkTU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSTt9tAAoJEKeha0olJ0NqiZoIAJv3lqm7QBSfRwDCk22xzU2G xkzNqEap0TGx8GueVW6ctVUTbUwRP5YymboMGUD76J5uYCm8e0s0RoDq2tuGgRZM MHX4iMkJKmVIEczhMRU01XZ5r9ogmFwxtFkn10WrxDr3TaGiuGn9GSrqjGzJK6OW cuVxrCq22kXJ392kCAw5fUeHBjoG9Jy0X+at3Ta+cRieAOjNSa2XE0YMR3FQ+vPn Pg7JwpnPSxAQlYkxf/t4njIiUxcEEwtXcnAEKESzYptLXqsMDlcjkO442W4PpdM1 QPnpVdUhtEayW7HQ00FC6Zjq1TRCpbQlPc3kTTwdbKgH4KjTldC8mC15yuys7bA= =LxxS -----END PGP SIGNATURE----- --DN1alxx09xrPrw9xN6sAEhgRnfdgGUkTU--