* [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
@ 2013-08-12 22:02 Paolo Bonzini
2013-08-26 12:21 ` Paolo Bonzini
2013-08-31 0:14 ` [Qemu-devel] [Qemu-stable] " Cole Robinson
0 siblings, 2 replies; 11+ messages in thread
From: Paolo Bonzini @ 2013-08-12 22:02 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-stable
vapic requires the VAPIC ROM to be mapped into RAM. This is not
possible without PAM hardware. This fixes a segmentation fault
running with -M isapc.
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index a19e172..3aa244a 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
.init = pc_init_isa,
.max_cpus = 1,
.compat_props = (GlobalProperty[]) {
+ {
+ .driver = "apic-common",
+ .property = "kvmvapic",
+ .value = "off",
+ },
{ /* end of list */ }
},
DEFAULT_MACHINE_OPTIONS,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-12 22:02 [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic Paolo Bonzini
@ 2013-08-26 12:21 ` Paolo Bonzini
2013-08-26 14:34 ` Andreas Färber
2013-08-31 0:14 ` [Qemu-devel] [Qemu-stable] " Cole Robinson
1 sibling, 1 reply; 11+ messages in thread
From: Paolo Bonzini @ 2013-08-26 12:21 UTC (permalink / raw)
Cc: qemu-devel, qemu-stable
Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
> vapic requires the VAPIC ROM to be mapped into RAM. This is not
> possible without PAM hardware. This fixes a segmentation fault
> running with -M isapc.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index a19e172..3aa244a 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
> .init = pc_init_isa,
> .max_cpus = 1,
> .compat_props = (GlobalProperty[]) {
> + {
> + .driver = "apic-common",
> + .property = "kvmvapic",
> + .value = "off",
> + },
> { /* end of list */ }
> },
> DEFAULT_MACHINE_OPTIONS,
>
Ping.
Paolo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-26 12:21 ` Paolo Bonzini
@ 2013-08-26 14:34 ` Andreas Färber
2013-08-26 15:01 ` Paolo Bonzini
0 siblings, 1 reply; 11+ messages in thread
From: Andreas Färber @ 2013-08-26 14:34 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, qemu-stable
Am 26.08.2013 14:21, schrieb Paolo Bonzini:
> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
>> possible without PAM hardware. This fixes a segmentation fault
>> running with -M isapc.
>>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>
>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>> index a19e172..3aa244a 100644
>> --- a/hw/i386/pc_piix.c
>> +++ b/hw/i386/pc_piix.c
>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>> .init = pc_init_isa,
>> .max_cpus = 1,
>> .compat_props = (GlobalProperty[]) {
>> + {
>> + .driver = "apic-common",
>> + .property = "kvmvapic",
>> + .value = "off",
>> + },
>> { /* end of list */ }
>> },
>> DEFAULT_MACHINE_OPTIONS,
>>
>
> Ping.
I had double-checked that my pending qom-test covers isapc and succeeds
with and without your patch, so apparently this is visible at runtime only.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-26 14:34 ` Andreas Färber
@ 2013-08-26 15:01 ` Paolo Bonzini
2013-08-26 15:17 ` Andreas Färber
0 siblings, 1 reply; 11+ messages in thread
From: Paolo Bonzini @ 2013-08-26 15:01 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel, qemu-stable
Il 26/08/2013 16:34, Andreas Färber ha scritto:
> Am 26.08.2013 14:21, schrieb Paolo Bonzini:
>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
>>> possible without PAM hardware. This fixes a segmentation fault
>>> running with -M isapc.
>>>
>>> Cc: qemu-stable@nongnu.org
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>
>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>>> index a19e172..3aa244a 100644
>>> --- a/hw/i386/pc_piix.c
>>> +++ b/hw/i386/pc_piix.c
>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>>> .init = pc_init_isa,
>>> .max_cpus = 1,
>>> .compat_props = (GlobalProperty[]) {
>>> + {
>>> + .driver = "apic-common",
>>> + .property = "kvmvapic",
>>> + .value = "off",
>>> + },
>>> { /* end of list */ }
>>> },
>>> DEFAULT_MACHINE_OPTIONS,
>>>
>>
>> Ping.
>
> I had double-checked that my pending qom-test covers isapc and succeeds
> with and without your patch, so apparently this is visible at runtime only.
Yes, it only happens after kvmvapic is actually enabled by the option ROM.
Paolo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-26 15:01 ` Paolo Bonzini
@ 2013-08-26 15:17 ` Andreas Färber
2013-08-26 16:17 ` Michael S. Tsirkin
0 siblings, 1 reply; 11+ messages in thread
From: Andreas Färber @ 2013-08-26 15:17 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Michael S. Tsirkin, qemu-devel, qemu-stable
Am 26.08.2013 17:01, schrieb Paolo Bonzini:
> Il 26/08/2013 16:34, Andreas Färber ha scritto:
>> Am 26.08.2013 14:21, schrieb Paolo Bonzini:
>>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
>>>> possible without PAM hardware. This fixes a segmentation fault
>>>> running with -M isapc.
>>>>
>>>> Cc: qemu-stable@nongnu.org
>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>> ---
>>>>
>>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>>>> index a19e172..3aa244a 100644
>>>> --- a/hw/i386/pc_piix.c
>>>> +++ b/hw/i386/pc_piix.c
>>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>>>> .init = pc_init_isa,
>>>> .max_cpus = 1,
>>>> .compat_props = (GlobalProperty[]) {
>>>> + {
>>>> + .driver = "apic-common",
>>>> + .property = "kvmvapic",
>>>> + .value = "off",
>>>> + },
>>>> { /* end of list */ }
>>>> },
>>>> DEFAULT_MACHINE_OPTIONS,
>>>>
>>>
>>> Ping.
>>
>> I had double-checked that my pending qom-test covers isapc and succeeds
>> with and without your patch, so apparently this is visible at runtime only.
>
> Yes, it only happens after kvmvapic is actually enabled by the option ROM.
Maybe Michael can pick it up along with the compat refactorings?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-26 15:17 ` Andreas Färber
@ 2013-08-26 16:17 ` Michael S. Tsirkin
2013-10-04 16:47 ` Paolo Bonzini
0 siblings, 1 reply; 11+ messages in thread
From: Michael S. Tsirkin @ 2013-08-26 16:17 UTC (permalink / raw)
To: Andreas Färber; +Cc: Paolo Bonzini, qemu-devel, qemu-stable
On Mon, Aug 26, 2013 at 05:17:07PM +0200, Andreas Färber wrote:
> Am 26.08.2013 17:01, schrieb Paolo Bonzini:
> > Il 26/08/2013 16:34, Andreas Färber ha scritto:
> >> Am 26.08.2013 14:21, schrieb Paolo Bonzini:
> >>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
> >>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
> >>>> possible without PAM hardware. This fixes a segmentation fault
> >>>> running with -M isapc.
> >>>>
> >>>> Cc: qemu-stable@nongnu.org
> >>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>>> ---
> >>>>
> >>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> >>>> index a19e172..3aa244a 100644
> >>>> --- a/hw/i386/pc_piix.c
> >>>> +++ b/hw/i386/pc_piix.c
> >>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
> >>>> .init = pc_init_isa,
> >>>> .max_cpus = 1,
> >>>> .compat_props = (GlobalProperty[]) {
> >>>> + {
> >>>> + .driver = "apic-common",
> >>>> + .property = "kvmvapic",
> >>>> + .value = "off",
> >>>> + },
> >>>> { /* end of list */ }
> >>>> },
> >>>> DEFAULT_MACHINE_OPTIONS,
> >>>>
> >>>
> >>> Ping.
> >>
> >> I had double-checked that my pending qom-test covers isapc and succeeds
> >> with and without your patch, so apparently this is visible at runtime only.
> >
> > Yes, it only happens after kvmvapic is actually enabled by the option ROM.
>
> Maybe Michael can pick it up along with the compat refactorings?
>
> Andreas
Sure, I'll put it on my tree but I already prepared a pull request
for today, it will go into the next one.
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-12 22:02 [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic Paolo Bonzini
2013-08-26 12:21 ` Paolo Bonzini
@ 2013-08-31 0:14 ` Cole Robinson
2013-09-25 21:31 ` Doug Goldstein
1 sibling, 1 reply; 11+ messages in thread
From: Cole Robinson @ 2013-08-31 0:14 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, qemu-stable
On 08/12/2013 06:02 PM, Paolo Bonzini wrote:
> vapic requires the VAPIC ROM to be mapped into RAM. This is not
> possible without PAM hardware. This fixes a segmentation fault
> running with -M isapc.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index a19e172..3aa244a 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
> .init = pc_init_isa,
> .max_cpus = 1,
> .compat_props = (GlobalProperty[]) {
> + {
> + .driver = "apic-common",
> + .property = "kvmvapic",
> + .value = "off",
> + },
> { /* end of list */ }
> },
> DEFAULT_MACHINE_OPTIONS,
>
There's a Fedora bug about a related invocation crashing:
./x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -m 128 -vga std -boot d
-cpu pentium -machine isapc
https://bugzilla.redhat.com/show_bug.cgi?id=986790
So I tried your patch on git master, but it gives:
qemu-system-x86_64: Property '.kvmvapic' not found
Changing the property name to 'vapic' fixes both issues for me.
Thanks,
Cole
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-31 0:14 ` [Qemu-devel] [Qemu-stable] " Cole Robinson
@ 2013-09-25 21:31 ` Doug Goldstein
0 siblings, 0 replies; 11+ messages in thread
From: Doug Goldstein @ 2013-09-25 21:31 UTC (permalink / raw)
To: Cole Robinson; +Cc: Paolo Bonzini, qemu-devel, qemu-stable
On Fri, Aug 30, 2013 at 7:14 PM, Cole Robinson <crobinso@redhat.com> wrote:
> On 08/12/2013 06:02 PM, Paolo Bonzini wrote:
>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
>> possible without PAM hardware. This fixes a segmentation fault
>> running with -M isapc.
>>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>
>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>> index a19e172..3aa244a 100644
>> --- a/hw/i386/pc_piix.c
>> +++ b/hw/i386/pc_piix.c
>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>> .init = pc_init_isa,
>> .max_cpus = 1,
>> .compat_props = (GlobalProperty[]) {
>> + {
>> + .driver = "apic-common",
>> + .property = "kvmvapic",
>> + .value = "off",
>> + },
>> { /* end of list */ }
>> },
>> DEFAULT_MACHINE_OPTIONS,
>>
>
> There's a Fedora bug about a related invocation crashing:
>
> ./x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -m 128 -vga std -boot d
> -cpu pentium -machine isapc
>
> https://bugzilla.redhat.com/show_bug.cgi?id=986790
>
> So I tried your patch on git master, but it gives:
>
> qemu-system-x86_64: Property '.kvmvapic' not found
>
> Changing the property name to 'vapic' fixes both issues for me.
>
> Thanks,
> Cole
>
Ping this patch. I had to make the same change as Cole for Gentoo as well.
--
Doug Goldstein
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-08-26 16:17 ` Michael S. Tsirkin
@ 2013-10-04 16:47 ` Paolo Bonzini
2013-10-04 16:52 ` Andreas Färber
0 siblings, 1 reply; 11+ messages in thread
From: Paolo Bonzini @ 2013-10-04 16:47 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-stable, Andreas Färber, qemu-devel
Il 26/08/2013 18:17, Michael S. Tsirkin ha scritto:
> On Mon, Aug 26, 2013 at 05:17:07PM +0200, Andreas Färber wrote:
>> Am 26.08.2013 17:01, schrieb Paolo Bonzini:
>>> Il 26/08/2013 16:34, Andreas Färber ha scritto:
>>>> Am 26.08.2013 14:21, schrieb Paolo Bonzini:
>>>>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>>>>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
>>>>>> possible without PAM hardware. This fixes a segmentation fault
>>>>>> running with -M isapc.
>>>>>>
>>>>>> Cc: qemu-stable@nongnu.org
>>>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>>>> ---
>>>>>>
>>>>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>>>>>> index a19e172..3aa244a 100644
>>>>>> --- a/hw/i386/pc_piix.c
>>>>>> +++ b/hw/i386/pc_piix.c
>>>>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>>>>>> .init = pc_init_isa,
>>>>>> .max_cpus = 1,
>>>>>> .compat_props = (GlobalProperty[]) {
>>>>>> + {
>>>>>> + .driver = "apic-common",
>>>>>> + .property = "kvmvapic",
>>>>>> + .value = "off",
>>>>>> + },
>>>>>> { /* end of list */ }
>>>>>> },
>>>>>> DEFAULT_MACHINE_OPTIONS,
>>>>>>
>>>>>
>>>>> Ping.
>>>>
>>>> I had double-checked that my pending qom-test covers isapc and succeeds
>>>> with and without your patch, so apparently this is visible at runtime only.
>>>
>>> Yes, it only happens after kvmvapic is actually enabled by the option ROM.
>>
>> Maybe Michael can pick it up along with the compat refactorings?
>>
>> Andreas
>
> Sure, I'll put it on my tree but I already prepared a pull request
> for today, it will go into the next one.
Michael, can you post this patch together with the ACPI pull request?
Paolo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-10-04 16:47 ` Paolo Bonzini
@ 2013-10-04 16:52 ` Andreas Färber
2013-10-04 19:05 ` Paolo Bonzini
0 siblings, 1 reply; 11+ messages in thread
From: Andreas Färber @ 2013-10-04 16:52 UTC (permalink / raw)
To: Paolo Bonzini
Cc: qemu-stable, Cole Robinson, Doug Goldstein, qemu-devel,
Michael S. Tsirkin
Am 04.10.2013 18:47, schrieb Paolo Bonzini:
> Il 26/08/2013 18:17, Michael S. Tsirkin ha scritto:
>> On Mon, Aug 26, 2013 at 05:17:07PM +0200, Andreas Färber wrote:
>>> Am 26.08.2013 17:01, schrieb Paolo Bonzini:
>>>> Il 26/08/2013 16:34, Andreas Färber ha scritto:
>>>>> Am 26.08.2013 14:21, schrieb Paolo Bonzini:
>>>>>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>>>>>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
>>>>>>> possible without PAM hardware. This fixes a segmentation fault
>>>>>>> running with -M isapc.
>>>>>>>
>>>>>>> Cc: qemu-stable@nongnu.org
>>>>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>>>>> ---
>>>>>>>
>>>>>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>>>>>>> index a19e172..3aa244a 100644
>>>>>>> --- a/hw/i386/pc_piix.c
>>>>>>> +++ b/hw/i386/pc_piix.c
>>>>>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>>>>>>> .init = pc_init_isa,
>>>>>>> .max_cpus = 1,
>>>>>>> .compat_props = (GlobalProperty[]) {
>>>>>>> + {
>>>>>>> + .driver = "apic-common",
>>>>>>> + .property = "kvmvapic",
>>>>>>> + .value = "off",
>>>>>>> + },
>>>>>>> { /* end of list */ }
>>>>>>> },
>>>>>>> DEFAULT_MACHINE_OPTIONS,
>>>>>>>
>>>>>>
>>>>>> Ping.
>>>>>
>>>>> I had double-checked that my pending qom-test covers isapc and succeeds
>>>>> with and without your patch, so apparently this is visible at runtime only.
>>>>
>>>> Yes, it only happens after kvmvapic is actually enabled by the option ROM.
>>>
>>> Maybe Michael can pick it up along with the compat refactorings?
>>
>> Sure, I'll put it on my tree but I already prepared a pull request
>> for today, it will go into the next one.
>
> Michael, can you post this patch together with the ACPI pull request?
What about the comment wrt s/kvmvapic/vapic/g? Haven't seen any response
or v2.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
2013-10-04 16:52 ` Andreas Färber
@ 2013-10-04 19:05 ` Paolo Bonzini
0 siblings, 0 replies; 11+ messages in thread
From: Paolo Bonzini @ 2013-10-04 19:05 UTC (permalink / raw)
To: Andreas Färber
Cc: qemu-devel, Doug Goldstein, Michael S. Tsirkin, qemu-stable,
Cole Robinson
Il 04/10/2013 18:52, Andreas Färber ha scritto:
> Am 04.10.2013 18:47, schrieb Paolo Bonzini:
>> Il 26/08/2013 18:17, Michael S. Tsirkin ha scritto:
>>> On Mon, Aug 26, 2013 at 05:17:07PM +0200, Andreas Färber wrote:
>>>> Am 26.08.2013 17:01, schrieb Paolo Bonzini:
>>>>> Il 26/08/2013 16:34, Andreas Färber ha scritto:
>>>>>> Am 26.08.2013 14:21, schrieb Paolo Bonzini:
>>>>>>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>>>>>>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not
>>>>>>>> possible without PAM hardware. This fixes a segmentation fault
>>>>>>>> running with -M isapc.
>>>>>>>>
>>>>>>>> Cc: qemu-stable@nongnu.org
>>>>>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>>>>>> ---
>>>>>>>>
>>>>>>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>>>>>>>> index a19e172..3aa244a 100644
>>>>>>>> --- a/hw/i386/pc_piix.c
>>>>>>>> +++ b/hw/i386/pc_piix.c
>>>>>>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine = {
>>>>>>>> .init = pc_init_isa,
>>>>>>>> .max_cpus = 1,
>>>>>>>> .compat_props = (GlobalProperty[]) {
>>>>>>>> + {
>>>>>>>> + .driver = "apic-common",
>>>>>>>> + .property = "kvmvapic",
>>>>>>>> + .value = "off",
>>>>>>>> + },
>>>>>>>> { /* end of list */ }
>>>>>>>> },
>>>>>>>> DEFAULT_MACHINE_OPTIONS,
>>>>>>>>
>>>>>>>
>>>>>>> Ping.
>>>>>>
>>>>>> I had double-checked that my pending qom-test covers isapc and succeeds
>>>>>> with and without your patch, so apparently this is visible at runtime only.
>>>>>
>>>>> Yes, it only happens after kvmvapic is actually enabled by the option ROM.
>>>>
>>>> Maybe Michael can pick it up along with the compat refactorings?
>>>
>>> Sure, I'll put it on my tree but I already prepared a pull request
>>> for today, it will go into the next one.
>>
>> Michael, can you post this patch together with the ACPI pull request?
>
> What about the comment wrt s/kvmvapic/vapic/g? Haven't seen any response
> or v2.
It needs a v2 indeed... weird...
Paolo
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-10-04 19:06 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12 22:02 [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic Paolo Bonzini
2013-08-26 12:21 ` Paolo Bonzini
2013-08-26 14:34 ` Andreas Färber
2013-08-26 15:01 ` Paolo Bonzini
2013-08-26 15:17 ` Andreas Färber
2013-08-26 16:17 ` Michael S. Tsirkin
2013-10-04 16:47 ` Paolo Bonzini
2013-10-04 16:52 ` Andreas Färber
2013-10-04 19:05 ` Paolo Bonzini
2013-08-31 0:14 ` [Qemu-devel] [Qemu-stable] " Cole Robinson
2013-09-25 21:31 ` Doug Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).