From: Richard Henderson <richard.henderson@linaro.org>
To: Matthieu Bucchianeri <matthieu.bucchianeri@leostella.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
qemu-trivial@nongnu.org
Cc: david@gibson.dropbear.id.au
Subject: Re: [PATCH] target/ppc: Fix TCG leak with the evmwsmiaa instruction
Date: Mon, 27 Jul 2020 10:26:31 -0700 [thread overview]
Message-ID: <524ad0cb-0d91-70b1-9e14-55a070ca8270@linaro.org> (raw)
In-Reply-To: <20200727172114.31415-1-matthieu.bucchianeri@leostella.com>
On 7/27/20 10:21 AM, Matthieu Bucchianeri wrote:
> Fix double-call to tcg_temp_new_i64(), where a temp is allocated both at
> declaration time and further down the implementation of gen_evmwsmiaa().
>
> Note that gen_evmwsmia() and gen_evmwsmiaa() are still not implemented
> correctly, as they invoke gen_evmwsmi() which may return early, but the
> return is not propagated. This will be fixed in my patch for bug #1888918.
>
> Signed-off-by: Matthieu Bucchianeri <matthieu.bucchianeri@leostella.com>
> ---
> target/ppc/translate/spe-impl.inc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-07-27 17:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 17:21 [PATCH] target/ppc: Fix TCG leak with the evmwsmiaa instruction Matthieu Bucchianeri
2020-07-27 17:26 ` Richard Henderson [this message]
2020-07-28 3:53 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524ad0cb-0d91-70b1-9e14-55a070ca8270@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=matthieu.bucchianeri@leostella.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).