qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset
Date: Sun, 06 Oct 2013 22:34:53 +0200	[thread overview]
Message-ID: <5251C96D.1020709@redhat.com> (raw)
In-Reply-To: <20131006182806.GA16531@redhat.com>

Il 06/10/2013 20:28, Michael S. Tsirkin ha scritto:
> > > > For each PCI device I tried creating a VM with an instance of it (a few
> > > > devices at a time), and did VM resets.  Earlier versions were tested by
> > > > the guy who reported the SCSI problems.
> > > 
> > > x86 kvm only?
> > 
> > Yes.
> 
> Hmm, I'm not sure that's enough for this kind of change.

I'll do more tests though, from looking at the source code, I'm not sure
what could happen depending on the host bridge.  To make it clearer, the
difference is that pre-patch you have

    device-level reset for device 1
    bus-level reset for device 1
    device-level reset for device 2
    bus-level reset for device 2
    device-level reset for device 3
    bus-level reset for device 3

and afterwards you have

    device-level reset for device 1
    device-level reset for device 2
    device-level reset for device 3
    bus-level reset for device 1
    bus-level reset for device 2
    bus-level reset for device 3

I could also preserve exactly the same semantics if you prefer.  The
patch is a bit more complicated, but it's doable.

Paolo

  reply	other threads:[~2013-10-06 20:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03 13:46 [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 1/4] pci: do not export pci_bus_reset Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 2/4] pci: clean up resetting of IRQs Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 3/4] qdev: allow both pre- and post-order vists in qdev walking functions Paolo Bonzini
2013-10-03 13:46 ` [Qemu-devel] [PATCH 4/4] qdev: switch reset to post-order Paolo Bonzini
2013-10-03 13:54 ` [Qemu-devel] [PATCH 0/4] qdev: switch reset to post-order, clean up PCI reset Michael S. Tsirkin
2013-10-03 15:58   ` Paolo Bonzini
2013-10-03 16:54     ` Michael S. Tsirkin
2013-10-03 16:53       ` Paolo Bonzini
2013-10-06 18:28         ` Michael S. Tsirkin
2013-10-06 20:34           ` Paolo Bonzini [this message]
2013-10-09 16:10             ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2013-12-06 16:54 Paolo Bonzini
2013-12-19 19:15 ` Michael S. Tsirkin
2013-12-19 23:45   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5251C96D.1020709@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).