From: Fabien Chouteau <chouteau@adacore.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>,
"Luiz Capitulino" <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands
Date: Mon, 07 Oct 2013 12:12:45 +0200 [thread overview]
Message-ID: <5252891D.7050200@adacore.com> (raw)
In-Reply-To: <CAFEAcA-1GOS5z2m_WKLMJCoVBaeGiEG1ZqOPV6QS+UNON_DvaQ@mail.gmail.com>
On 10/04/2013 07:52 PM, Peter Maydell wrote:
>> +#include "monitor/monitor_def.h"
>> +
>> +const MonitorDef arm_monitor_defs[] = {
>> + { "r0", offsetof(CPUARMState, regs[0]) },
>> + { "r1", offsetof(CPUARMState, regs[1]) },
>
> These fields are all 32 bits, not target_long,
> so they need to be marked as MD_I32. (If you build an
> aarch64-softmmu target then it will have target_long be
> 64 bit but still support all the 32 bit CPUs, so it does
> make a difference.)
>
OK, I'll mark them MD_I32.
--
Fabien Chouteau
next prev parent reply other threads:[~2013-10-07 10:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 16:56 [Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v4) Fabien Chouteau
2013-10-04 16:57 ` [Qemu-devel] [PATCH 1/4] Fix coding style Fabien Chouteau
2013-10-04 16:57 ` [Qemu-devel] [PATCH 2/4] Improve Monitor disas with symbol lookup Fabien Chouteau
2013-10-04 16:57 ` [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array Fabien Chouteau
2013-10-04 17:49 ` Peter Maydell
2013-10-04 17:55 ` Andreas Färber
2013-10-07 10:11 ` Fabien Chouteau
2013-10-07 11:45 ` Peter Maydell
2013-10-07 13:06 ` Fabien Chouteau
2013-10-07 13:29 ` Peter Maydell
2013-10-07 14:40 ` Fabien Chouteau
2013-10-04 16:57 ` [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands Fabien Chouteau
2013-10-04 17:52 ` Peter Maydell
2013-10-07 10:12 ` Fabien Chouteau [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-30 15:57 [Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v3) Fabien Chouteau
2013-09-30 15:57 ` [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands Fabien Chouteau
2013-10-01 1:12 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5252891D.7050200@adacore.com \
--to=chouteau@adacore.com \
--cc=afaerber@suse.de \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).