From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54717)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1VT7o4-0000S5-9C
	for qemu-devel@nongnu.org; Mon, 07 Oct 2013 06:12:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1VT7ny-0005kf-A9
	for qemu-devel@nongnu.org; Mon, 07 Oct 2013 06:12:52 -0400
Received: from mel.act-europe.fr ([194.98.77.210]:48816
	helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1VT7ny-0005kZ-3s
	for qemu-devel@nongnu.org; Mon, 07 Oct 2013 06:12:46 -0400
Message-ID: <5252891D.7050200@adacore.com>
Date: Mon, 07 Oct 2013 12:12:45 +0200
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1380905823-3981-1-git-send-email-chouteau@adacore.com>
	<1380905823-3981-5-git-send-email-chouteau@adacore.com>
	<CAFEAcA-1GOS5z2m_WKLMJCoVBaeGiEG1ZqOPV6QS+UNON_DvaQ@mail.gmail.com>
In-Reply-To: <CAFEAcA-1GOS5z2m_WKLMJCoVBaeGiEG1ZqOPV6QS+UNON_DvaQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for
	Monitor commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Luiz Capitulino <lcapitulino@redhat.com>

On 10/04/2013 07:52 PM, Peter Maydell wrote:
>> +#include "monitor/monitor_def.h"
>> +
>> +const MonitorDef arm_monitor_defs[] = {
>> +    { "r0",     offsetof(CPUARMState, regs[0])  },
>> +    { "r1",     offsetof(CPUARMState, regs[1])  },
> 
> These fields are all 32 bits, not target_long,
> so they need to be marked as MD_I32. (If you build an
> aarch64-softmmu target then it will have target_long be
> 64 bit but still support all the 32 bit CPUs, so it does
> make a difference.)
> 

OK, I'll mark them MD_I32.

-- 
Fabien Chouteau