From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTIbQ-0002HU-8P for qemu-devel@nongnu.org; Mon, 07 Oct 2013 17:44:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTIbL-0004hm-BK for qemu-devel@nongnu.org; Mon, 07 Oct 2013 17:44:32 -0400 Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:46674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTIbL-0004hP-5X for qemu-devel@nongnu.org; Mon, 07 Oct 2013 17:44:27 -0400 Received: by mail-ee0-f44.google.com with SMTP id b47so3575023eek.17 for ; Mon, 07 Oct 2013 14:44:25 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52532B35.60004@redhat.com> Date: Mon, 07 Oct 2013 23:44:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix pc migration from qemu <= 1.5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cole Robinson Cc: mst@redhat.com, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Il 07/10/2013 22:57, Cole Robinson ha scritto: > The following commit introduced a migration incompatibility: > > commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe > Author: David Gibson > Date: Thu Jun 6 18:48:49 2013 +1000 > > pci: Replace pci_find_domain() with more general pci_root_bus_path() > > The issue is that i440fx savevm idstr went from 0000:00:00.0/I440FX to > 0000:00.0/I440FX. Unfortunately we are stuck with the breakage for > 1.6 machine types. > > Add a compat property to maintain the busted idstr for the 1.6 machine > types, but revert to the old style format for 1.7+, and <= 1.5. > > Tested with migration from qemu 1.5, qemu 1.6, and qemu.git. > > Signed-off-by: Cole Robinson Reviewed-by: Paolo Bonzini