From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTTfq-0004Dl-Mi for qemu-devel@nongnu.org; Tue, 08 Oct 2013 05:33:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTTfk-0000gb-N7 for qemu-devel@nongnu.org; Tue, 08 Oct 2013 05:33:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTTfk-0000gO-ES for qemu-devel@nongnu.org; Tue, 08 Oct 2013 05:33:44 -0400 Message-ID: <5253D174.1060200@redhat.com> Date: Tue, 08 Oct 2013 11:33:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5253C514.6090103@ozlabs.ru> <5253CAB5.7040708@redhat.com> <20131008092330.GB25109@dhcp-200-207.str.redhat.com> In-Reply-To: <20131008092330.GB25109@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] savevm/loadvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Alexey Kardashevskiy , "qemu-devel@nongnu.org" Il 08/10/2013 11:23, Kevin Wolf ha scritto: >> > I think you need to modify qcow2_save_vmstate to save and restore >> > bs->total_sectors. Can you test that and if so post the patch? > It's a regression introduced by commit df2a6f29, right? Yes, that's what introduced the "if". > What you suggest probably works as a quick hack to fix the bug. The VM > state functions in qcow2 are getting uglier and uglier, though. Maybe > they should avoid going through block.c and adding hacks to disable or > revert side effects. Yes, that would work too. Paolo