From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, anthony@codemonkey.ws, stefanha@redhat.com,
qemu-devel@nongnu.org, ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices
Date: Tue, 08 Oct 2013 14:36:13 +0200 [thread overview]
Message-ID: <5253FC3D.9050704@redhat.com> (raw)
In-Reply-To: <5253F514.2050101@kamp.de>
Il 08/10/2013 14:05, Peter Lieven ha scritto:
>> Strictly speaking, this should probably do something like this:
>>
>> assert(ret & BDRV_BLOCK_OFFSET_VALID);
>> return bdrv_get_block_status(bs->file, ret >> BDRV_SECTOR_BITS,
>> nb_sectors, pnum);
> shouldn't the last line be:
>
> return bdrv_get_block_status(bs->file, ret >> BDRV_SECTOR_BITS,
> *pnum, pnum);
>
>
> This would of course require *pnum = nb_sectors in raw_co_get_block_status
> ?
Yes for both questions.
Paolo
prev parent reply other threads:[~2013-10-08 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 5:59 [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices Peter Lieven
2013-10-07 8:25 ` Paolo Bonzini
2013-10-07 9:25 ` Peter Lieven
2013-10-08 11:13 ` Stefan Hajnoczi
2013-10-08 12:05 ` Peter Lieven
2013-10-08 12:36 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5253FC3D.9050704@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).