From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: make use of new BlockJobType
Date: Tue, 08 Oct 2013 07:06:15 -0600 [thread overview]
Message-ID: <52540347.6040600@redhat.com> (raw)
In-Reply-To: <1381224580-14950-4-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On 10/08/2013 03:29 AM, Fam Zheng wrote:
> Switch the string to enum type BlockJobType in BlockJobDriver.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> +++ b/include/block/blockjob.h
> @@ -37,7 +37,7 @@ typedef struct BlockJobDriver {
> size_t instance_size;
>
> /** String describing the operation, part of query-block-jobs QMP API */
> - const char *job_type;
> + BlockJobType job_type;
Comment looks awkward now that it is not a string in memory; but it is
still a string on the wire, so I can live with it as-is.
Series: Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks for doing this!
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-08 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 9:29 [Qemu-devel] [PATCH 0/3] qapi: introduce BlockJobType enum Fam Zheng
2013-10-08 9:29 ` [Qemu-devel] [PATCH 1/3] blockjob: rename BlockJobType to BlockJobDriver Fam Zheng
2013-10-08 9:29 ` [Qemu-devel] [PATCH 2/3] qapi: Introduce enum BlockJobType Fam Zheng
2013-10-08 9:29 ` [Qemu-devel] [PATCH 3/3] qapi: make use of new BlockJobType Fam Zheng
2013-10-08 13:06 ` Eric Blake [this message]
2013-10-08 12:49 ` [Qemu-devel] [PATCH 0/3] qapi: introduce BlockJobType enum Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52540347.6040600@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).