From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTWzX-0004lP-FQ for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:06:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTWzS-0003Fq-KB for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:06:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTWzS-0003Fl-Af for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:06:18 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r98D6Hg1025597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Oct 2013 09:06:17 -0400 Message-ID: <52540347.6040600@redhat.com> Date: Tue, 08 Oct 2013 07:06:15 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381224580-14950-1-git-send-email-famz@redhat.com> <1381224580-14950-4-git-send-email-famz@redhat.com> In-Reply-To: <1381224580-14950-4-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ecNMBLbFtILM6MgUxtb2ahhxwjmk6l9M1" Subject: Re: [Qemu-devel] [PATCH 3/3] qapi: make use of new BlockJobType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ecNMBLbFtILM6MgUxtb2ahhxwjmk6l9M1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/08/2013 03:29 AM, Fam Zheng wrote: > Switch the string to enum type BlockJobType in BlockJobDriver. >=20 > Signed-off-by: Fam Zheng > --- > +++ b/include/block/blockjob.h > @@ -37,7 +37,7 @@ typedef struct BlockJobDriver { > size_t instance_size; > =20 > /** String describing the operation, part of query-block-jobs QMP = API */ > - const char *job_type; > + BlockJobType job_type; Comment looks awkward now that it is not a string in memory; but it is still a string on the wire, so I can live with it as-is. Series: Reviewed-by: Eric Blake Thanks for doing this! --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ecNMBLbFtILM6MgUxtb2ahhxwjmk6l9M1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSVANHAAoJEKeha0olJ0NqTUEH/AgHt9fXlbgpU3Myrz7USzjy QG/ZXbpvlmAUECI7SsuhXsBsGKmjiCAFxboHOd7Q4MnAmzMuHyIDwbHKLrsfaoja PocEGRmF/3vL3AEIGVjxNZdSdtNPmDBDu39jn9axhuHRKDIf4pE1fhySneWax2Ez c6hSHPw17kg9YwmIFF56NwBCq8huAQiOyOa+OJWExTMzprAffxNTK9daiNE0/jqE mOG2jibPJHnXuTpfG3DT3keIOsURp8GvmV/RqQZL1vsPHG5B1s9h5/K8OKTKqYuU 6i/eSohPFTozXHNndvIdsoyJh0eLjzgfE4oXuu1BAFmSArU6xmHBOZlZv7v3xmE= =Oy9a -----END PGP SIGNATURE----- --ecNMBLbFtILM6MgUxtb2ahhxwjmk6l9M1--