From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTX1e-00063A-K8 for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:08:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTX1W-0003qu-7s for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:08:34 -0400 Received: from mail-qe0-x232.google.com ([2607:f8b0:400d:c02::232]:35780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTX1W-0003qb-3K for qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:08:26 -0400 Received: by mail-qe0-f50.google.com with SMTP id a11so6567618qen.37 for ; Tue, 08 Oct 2013 06:08:25 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <525403C1.2060206@redhat.com> Date: Tue, 08 Oct 2013 15:08:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1381226311-23489-1-git-send-email-stefanha@redhat.com> <20131008122550.GD25109@dhcp-200-207.str.redhat.com> In-Reply-To: <20131008122550.GD25109@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] osdep: initialize glib threads in all QEMU tools List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: mario.dechenno@unina2.it, qemu-devel@nongnu.org, Stefan Hajnoczi Il 08/10/2013 14:25, Kevin Wolf ha scritto: > The glib documentation says: > > Since version 2.24, calling g_thread_init() multiple times is > allowed, but nothing happens except for the first call. > > I take that this means previously it wasn't allowed. qemu's configure > checks for a minimum version of 2.12, so we seems to support glib > versions that don't allow g_thread_init() to be called multiple times. > > Do we need to protect against this? I think that's the point of the "if (!g_thread_supported ())" tests. Paolo