From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTX94-0000kw-Ps for Qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:16:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTX8z-0006bb-KL for Qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:16:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTX8z-0006aH-BL for Qemu-devel@nongnu.org; Tue, 08 Oct 2013 09:16:09 -0400 Message-ID: <52540596.30305@redhat.com> Date: Tue, 08 Oct 2013 07:16:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381213399-11487-1-git-send-email-wudxw@linux.vnet.ibm.com> In-Reply-To: <1381213399-11487-1-git-send-email-wudxw@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d14eSGUfIL80heMIj0uw53JJSqa3L4igu" Subject: Re: [Qemu-devel] [PATCH v4] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu Cc: Michael Roth , Qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d14eSGUfIL80heMIj0uw53JJSqa3L4igu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/08/2013 12:23 AM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success.= > It has been documented in qga/qapi-schema.json already. This patch expo= ses > the 'success-response' flag by extending 'guest-info' command. With thi= s > change, the clients can handle the command response more flexibly. >=20 > Signed-off-by: Mark Wu > --- > Changes: > v4:=20 > Add signature of qmp_has_success_response per Michael. > v3:=20 > 1. treat cmd->options as a bitmask instead of single option (per Eric)= =20 > 2. rebase on the patch " Add interface to traverse the qmp command lis= t > by QmpCommand" to avoid the O(n2) problem (per Eric and Michael) > v2:=20 > add the notation 'since 1.7' to the option 'success-response' > (per Eric Blake's comments) >=20 > include/qapi/qmp/dispatch.h | 1 + > qapi/qmp-registry.c | 5 +++++ > qga/commands.c | 1 + > qga/qapi-schema.json | 5 ++++- > 4 files changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --d14eSGUfIL80heMIj0uw53JJSqa3L4igu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSVAWWAAoJEKeha0olJ0Nq/T0H/i8hfy7k0DzCMmpe0YAu1C9v PxiTwd8WvClgMFPQQQby2WRcjeNZ1Kp7lTxbfZlM/UX/UJcc4fDKsztaxiAoXsgH sY/+GofpxeN2d6JV3x57kdVLubK93mc8hbSHKPBYVlUF6jvvzzlpBuLhO49Fo5Vx +LAa8u8T8KjEd4iZ8MIe0OGv8ylvGubVb5XhD5iVZVICa+jlpgLuyTpNvXg1FK64 7Cu3NEBQUmjaLzy1379pGDf4fmi1PI9O9SV30xD2k401HZvzhETVZ229AROqp8Ip TauJyZSjSfLThAvuTqq0S1tBzjr5Jyo7HObx/8jgo/peNUce7AY+9HjNUPAXXVw= =y/Jo -----END PGP SIGNATURE----- --d14eSGUfIL80heMIj0uw53JJSqa3L4igu--