From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, knoel@redhat.com,
mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org,
owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com,
gokul@us.ibm.com, chegu_vinod@hp.com
Subject: Re: [Qemu-devel] [PATCH v3 resend 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition
Date: Tue, 08 Oct 2013 18:05:43 +0200 [thread overview]
Message-ID: <52542D57.30401@redhat.com> (raw)
In-Reply-To: <52541B75.7010704@redhat.com>
Il 08/10/2013 16:49, Eric Blake ha scritto:
> You are now returning a state that older libvirt versions are not
> expecting. Obviously, we can patch newer libvirt to make migration work
> again, but should we be thinking about damage control by stating that an
> older management app should still be able to drive migration on a new
> qemu? Or is it acceptable to state that newer qemu requires newer
> management tools?
We strive for that, but sometimes we break because we do not really know
what management expects from QEMU.
In this case, in particular, I think a capability is a bit overkill.
Libvirt needs to be somewhat liberal in what it accepts; in this case it
can treat any unknown state as "active".
Paolo
> If we try to support this working under older management tools, maybe
> the approach is that we have to add some new migration capability; newer
> management tools set the capability to true and are therefore allowed to
> see the new state name; older management tools do not set the capability
> and when that is the case we guarantee that we do not return a state
> string that the older tool is not expecting. Thoughts on whether we
> should pursue this?
>
next prev parent reply other threads:[~2013-10-08 16:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 14:01 [Qemu-devel] [PATCH v3 resend 0/8] rdma: core logic mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 1/8] rdma: update documentation to reflect new unpin support mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 2/8] rdma: bugfix: ram_control_save_page() mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 3/8] rdma: introduce ram_handle_compressed() mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 4/8] rdma: core logic mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 5/8] rdma: send pc.ram mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 6/8] rdma: allow state transitions between other states besides ACTIVE mrhines
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition mrhines
2013-10-08 14:49 ` Eric Blake
2013-10-08 16:05 ` Paolo Bonzini [this message]
2013-10-08 17:32 ` Michael R. Hines
2013-10-08 17:46 ` Eric Blake
2013-10-22 23:39 ` Chris Wulff
2013-07-22 14:01 ` [Qemu-devel] [PATCH v3 resend 8/8] rdma: account for the time spent in MIG_STATE_SETUP through QMP mrhines
-- strict thread matches above, loose matches on Subject: below --
2013-07-16 16:48 [Qemu-devel] [PATCH v3 resend 0/8] rdma: core logic mrhines
2013-07-16 16:48 ` [Qemu-devel] [PATCH v3 resend 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition mrhines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52542D57.30401@redhat.com \
--to=pbonzini@redhat.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=chegu_vinod@hp.com \
--cc=eblake@redhat.com \
--cc=gokul@us.ibm.com \
--cc=knoel@redhat.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).