From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTb8u-0007lV-SE for qemu-devel@nongnu.org; Tue, 08 Oct 2013 13:32:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTb8l-0004X4-Pc for qemu-devel@nongnu.org; Tue, 08 Oct 2013 13:32:20 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:44829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTb8l-0004WR-LM for qemu-devel@nongnu.org; Tue, 08 Oct 2013 13:32:11 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Oct 2013 13:32:09 -0400 Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 2BF636E8041 for ; Tue, 8 Oct 2013 13:32:06 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp23032.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r98HW7LG52166842 for ; Tue, 8 Oct 2013 17:32:07 GMT Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r98HW6q2030163 for ; Tue, 8 Oct 2013 14:32:06 -0300 Message-ID: <52544196.9000708@linux.vnet.ibm.com> Date: Tue, 08 Oct 2013 13:32:06 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1374501718-2581-1-git-send-email-mrhines@linux.vnet.ibm.com> <1374501718-2581-8-git-send-email-mrhines@linux.vnet.ibm.com> <52541B75.7010704@redhat.com> <52542D57.30401@redhat.com> In-Reply-To: <52542D57.30401@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 resend 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, quintela@redhat.com, chegu_vinod@hp.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, knoel@redhat.com On 10/08/2013 12:05 PM, Paolo Bonzini wrote: > Il 08/10/2013 16:49, Eric Blake ha scritto: >> You are now returning a state that older libvirt versions are not >> expecting. Obviously, we can patch newer libvirt to make migration work >> again, but should we be thinking about damage control by stating that an >> older management app should still be able to drive migration on a new >> qemu? Or is it acceptable to state that newer qemu requires newer >> management tools? > We strive for that, but sometimes we break because we do not really know > what management expects from QEMU. > > In this case, in particular, I think a capability is a bit overkill. > Libvirt needs to be somewhat liberal in what it accepts; in this case it > can treat any unknown state as "active". > > Paolo That makes sense to me too - the setup state is "effectively" the same as active and can be safely treated as such. There's a similar issue MigrationInfo statistics - what's the backwards/forwards-compatible procedure for not breaking libvirt when new statics appear? - such as "setup-time", which timestamps the new state that was introduced? - Michael for adding new statistics - Michael