From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTbN8-0005ET-PV for qemu-devel@nongnu.org; Tue, 08 Oct 2013 13:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTbN1-0001Py-8q for qemu-devel@nongnu.org; Tue, 08 Oct 2013 13:47:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTbN1-0001Pk-0E for qemu-devel@nongnu.org; Tue, 08 Oct 2013 13:46:55 -0400 Message-ID: <52544507.6080809@redhat.com> Date: Tue, 08 Oct 2013 11:46:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374501718-2581-1-git-send-email-mrhines@linux.vnet.ibm.com> <1374501718-2581-8-git-send-email-mrhines@linux.vnet.ibm.com> <52541B75.7010704@redhat.com> <52542D57.30401@redhat.com> <52544196.9000708@linux.vnet.ibm.com> In-Reply-To: <52544196.9000708@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l4EWQHefKNEdhKA9sIQRqHGNdLjDXcwiW" Subject: Re: [Qemu-devel] [PATCH v3 resend 7/8] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, Paolo Bonzini , chegu_vinod@hp.com, knoel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l4EWQHefKNEdhKA9sIQRqHGNdLjDXcwiW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/08/2013 11:32 AM, Michael R. Hines wrote: >> >> In this case, in particular, I think a capability is a bit overkill. >> Libvirt needs to be somewhat liberal in what it accepts; in this case = it >> can treat any unknown state as "active". >> >> Paolo >=20 > That makes sense to me too - the setup state is "effectively" the same > as active and can be safely treated as such. >=20 > There's a similar issue MigrationInfo statistics - what's the > backwards/forwards-compatible procedure for not breaking libvirt > when new statics appear? - such as "setup-time", which timestamps > the new state that was introduced? Libvirt ignores fields it does not expect. But for fields it expects, it was not ignoring new enum values within those fields that it was not expecting. The 'setup-time' change is not a problem (new field); only the new state ('setup') - and even then, Paolo is right that newer libvirt will be taught to be tolerant of unknown states, and that it is okay to require newer libvirt when using newer qemu (for example, when qemu 1.0 first came out, you had to upgrade to a new-enough libvirt that knew what to do with the different version number). So sounds like nothing further to worry about in qemu. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --l4EWQHefKNEdhKA9sIQRqHGNdLjDXcwiW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSVEUHAAoJEKeha0olJ0NqX78H/2voJiNqHIsrMoyQBKc4pOQr tmZeXrVTcnBvlJ/qpXBtPOe/n9m9bc56FjMGfpfEGW5HUmOcOWCNgM0l8txUl4OQ 1FoY6rd3LmH3xol/KpX/MkUWfqb4WtDgPaD86otAjYCGauTbpi33+Vs72N/BPD7Q MUQcxBhQmgrCiAJAABxAzm/RsPdOaCmHtdQtkOkIP46pTWctTeh7YyizpdA43OWb JVj7itkE4sk47fPEoPAYF3CrQdUO69KW8uz8VOi/JsbnsvBY1XNUmoiVWCgGbKXH TxYb5JiYqnAFzUY2I0qig16sP/D6gk9IdfbK2egueBmPwyWHSKgrS9CMTFk+dlw= =uHTp -----END PGP SIGNATURE----- --l4EWQHefKNEdhKA9sIQRqHGNdLjDXcwiW--