From: Paolo Bonzini <pbonzini@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>
Subject: Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events
Date: Tue, 08 Oct 2013 21:13:20 +0200 [thread overview]
Message-ID: <52545950.5070403@redhat.com> (raw)
In-Reply-To: <1381259403-7386-1-git-send-email-hdegoede@redhat.com>
Il 08/10/2013 21:10, Hans de Goede ha scritto:
> @@ -480,6 +480,11 @@ int main_loop_wait(int nonblocking)
> timerlistgroup_deadline_ns(
> &main_loop_tlg));
>
> + /* When not non-blocking always allow io-threads to acquire the lock */
> + if (timeout != 0 && timeout_ns == 0) {
> + timeout_ns = 1;
> + }
> +
This _is_ an I/O thread, so I guess this should be changed to "other
threads". Also, perhaps timeout_ns can be changed to a higher value
such as 250 us that were used up to the offending commit?
Otherwise looks good!
Paolo
next prev parent reply other threads:[~2013-10-08 19:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 19:10 [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events Hans de Goede
2013-10-08 19:13 ` Paolo Bonzini [this message]
2013-10-08 19:21 ` Hans de Goede
2013-10-08 19:33 ` Alex Bligh
2013-10-08 19:41 ` Hans de Goede
2013-10-08 20:01 ` Alex Bligh
2013-10-08 20:07 ` Alex Bligh
2013-10-08 20:16 ` Hans de Goede
2013-10-08 20:32 ` Alex Bligh
2013-10-08 20:50 ` Paolo Bonzini
2013-10-09 12:58 ` Hans de Goede
2013-10-09 13:18 ` Alex Bligh
2013-10-09 18:03 ` Hans de Goede
2013-10-09 18:15 ` Hans de Goede
2013-10-09 18:28 ` Alex Bligh
2013-10-09 18:36 ` Alex Bligh
2013-10-09 18:49 ` Hans de Goede
2013-10-09 19:03 ` Paolo Bonzini
2013-10-09 19:15 ` Hans de Goede
2013-10-09 14:37 ` Paolo Bonzini
2013-10-09 16:19 ` Alex Bligh
2013-10-09 16:26 ` Paolo Bonzini
2013-10-09 16:33 ` Alex Bligh
2013-10-09 17:53 ` Hans de Goede
2013-10-09 18:09 ` Hans de Goede
2013-10-08 19:48 ` Alex Bligh
2013-10-08 20:01 ` Hans de Goede
2013-10-08 21:25 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52545950.5070403@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex@alex.org.uk \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).