From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTeF0-0003Fx-Im for qemu-devel@nongnu.org; Tue, 08 Oct 2013 16:50:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTeEs-0005dW-1h for qemu-devel@nongnu.org; Tue, 08 Oct 2013 16:50:50 -0400 Received: from mail-ee0-x236.google.com ([2a00:1450:4013:c00::236]:53619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTeEr-0005dF-Ik for qemu-devel@nongnu.org; Tue, 08 Oct 2013 16:50:41 -0400 Received: by mail-ee0-f54.google.com with SMTP id e53so4320882eek.13 for ; Tue, 08 Oct 2013 13:50:40 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5254701B.5070804@redhat.com> Date: Tue, 08 Oct 2013 22:50:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1381259403-7386-1-git-send-email-hdegoede@redhat.com> <52545950.5070403@redhat.com> <52545B44.70005@redhat.com> <28EE4224-856B-4DC1-8159-A0C274BD269E@alex.org.uk> <52546000.6070308@redhat.com> <6CD4D4EE-341E-48D0-98F4-D55C0D3922D4@alex.org.uk> <52546832.9040900@redhat.com> In-Reply-To: <52546832.9040900@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org, Alex Bligh Il 08/10/2013 22:16, Hans de Goede ha scritto: > No, it is calling main_loop_wait with nonblocking set to 0, so > normally the lock would get released. But > timerlistgroup_deadline_ns(&main_loop_tlg) is returning 0, > causing timeout_ns to be 0, and this causes the lock to not get > released. Yes, this was my understanding of the patch as well. Before Alex's series, this would be capped to MIN_REARM_TIMER_NS (250 us). This is why I mentioned 250 us. However, I agree with Alex that it looks a bit fishy and I'd like to know what timer is it that is continuously set to expire in the past. Paolo