Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Sebastian Herbszt]

Brad Smith wrote:
> On 20/01/13 1:12 PM, David Woodhouse wrote:
>> The PCI Firmware Specification apparently requires that the PCI Data
>> Structure be DWORD-aligned. The implementation in OVMF also requires
>> this, so vgabios ROMs don't work there. With this fixed, I can now
>> initialise the VGA ROM from EFI, and EFI can display using INT 10h
>> services.
>>
>> --- vgabios-0.6c/vgabios.c.orig	2013-01-20 11:33:36.138548472
>> -0600 +++ vgabios-0.6c/vgabios.c	2013-01-20 11:36:26.060270163
>> -0600 @@ -204,6 +204,7 @@ vgabios_website:
>>   .byte	0x00
>>
>>   #ifdef PCIBIOS
>> +.align 4 // DWORD alignment required by PCI Firmware Specification
>>   vgabios_pci_data:
>>   .ascii "PCIR"
>>   #ifdef CIRRUS
> 
> We have had this in the OpenBSD port of QEMU for awhile now. Is it 
> possible to have this reviewed and commited?

This change was commited to upstream vgabios back in February [1].

[1]
http://cvs.savannah.gnu.org/viewvc/vgabios/vgabios.c?root=vgabios&view=log

Sebastian

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Brad Smith]

On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
> Brad Smith wrote:
>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>> The PCI Firmware Specification apparently requires that the PCI Data
>>> Structure be DWORD-aligned. The implementation in OVMF also requires
>>> this, so vgabios ROMs don't work there. With this fixed, I can now
>>> initialise the VGA ROM from EFI, and EFI can display using INT 10h
>>> services.
>>>
>>> --- vgabios-0.6c/vgabios.c.orig	2013-01-20 11:33:36.138548472
>>> -0600 +++ vgabios-0.6c/vgabios.c	2013-01-20 11:36:26.060270163
>>> -0600 @@ -204,6 +204,7 @@ vgabios_website:
>>>    .byte	0x00
>>>
>>>    #ifdef PCIBIOS
>>> +.align 4 // DWORD alignment required by PCI Firmware Specification
>>>    vgabios_pci_data:
>>>    .ascii "PCIR"
>>>    #ifdef CIRRUS
>>
>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>> possible to have this reviewed and commited?
>
> This change was commited to upstream vgabios back in February [1].

But that has not resulted in it being brought into QEMU.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Sebastian Herbszt]

Brad Smith wrote:
> On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
> > Brad Smith wrote:
> >> On 20/01/13 1:12 PM, David Woodhouse wrote:
> >>> The PCI Firmware Specification apparently requires that the PCI
> >>> Data Structure be DWORD-aligned. The implementation in OVMF also
> >>> requires this, so vgabios ROMs don't work there. With this fixed,
> >>> I can now initialise the VGA ROM from EFI, and EFI can display
> >>> using INT 10h services.
> >>>
> >>> --- vgabios-0.6c/vgabios.c.orig	2013-01-20
> >>> 11:33:36.138548472 -0600 +++ vgabios-0.6c/vgabios.c
> >>> 2013-01-20 11:36:26.060270163 -0600 @@ -204,6 +204,7 @@
> >>> vgabios_website: .byte	0x00
> >>>
> >>>    #ifdef PCIBIOS
> >>> +.align 4 // DWORD alignment required by PCI Firmware
> >>> Specification vgabios_pci_data:
> >>>    .ascii "PCIR"
> >>>    #ifdef CIRRUS
> >>
> >> We have had this in the OpenBSD port of QEMU for awhile now. Is it
> >> possible to have this reviewed and commited?
> >
> > This change was commited to upstream vgabios back in February [1].
> 
> But that has not resulted in it being brought into QEMU.

Gerd, Anthony, care to update QEMU's vgabios repository [1] with
changes from upstream CVS repository [2]?

[1] http://git.qemu.org/?p=vgabios.git
[2] http://cvs.savannah.gnu.org/viewvc/?root=vgabios

Sebastian

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Brad Smith]

On 21/09/13 12:38 PM, Sebastian Herbszt wrote:
> Brad Smith wrote:
>> On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
>>> Brad Smith wrote:
>>>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>>>> The PCI Firmware Specification apparently requires that the PCI
>>>>> Data Structure be DWORD-aligned. The implementation in OVMF also
>>>>> requires this, so vgabios ROMs don't work there. With this fixed,
>>>>> I can now initialise the VGA ROM from EFI, and EFI can display
>>>>> using INT 10h services.
>>>>>
>>>>> --- vgabios-0.6c/vgabios.c.orig	2013-01-20
>>>>> 11:33:36.138548472 -0600 +++ vgabios-0.6c/vgabios.c
>>>>> 2013-01-20 11:36:26.060270163 -0600 @@ -204,6 +204,7 @@
>>>>> vgabios_website: .byte	0x00
>>>>>
>>>>>     #ifdef PCIBIOS
>>>>> +.align 4 // DWORD alignment required by PCI Firmware
>>>>> Specification vgabios_pci_data:
>>>>>     .ascii "PCIR"
>>>>>     #ifdef CIRRUS
>>>>
>>>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>>>> possible to have this reviewed and commited?
>>>
>>> This change was commited to upstream vgabios back in February [1].
>>
>> But that has not resulted in it being brought into QEMU.
>
> Gerd, Anthony, care to update QEMU's vgabios repository [1] with
> changes from upstream CVS repository [2]?
>
> [1] http://git.qemu.org/?p=vgabios.git
> [2] http://cvs.savannah.gnu.org/viewvc/?root=vgabios

Any comment?

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Brad Smith]

On 25/09/13 7:24 PM, Brad Smith wrote:
> On 21/09/13 12:38 PM, Sebastian Herbszt wrote:
>> Brad Smith wrote:
>>> On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
>>>> Brad Smith wrote:
>>>>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>>>>> The PCI Firmware Specification apparently requires that the PCI
>>>>>> Data Structure be DWORD-aligned. The implementation in OVMF also
>>>>>> requires this, so vgabios ROMs don't work there. With this fixed,
>>>>>> I can now initialise the VGA ROM from EFI, and EFI can display
>>>>>> using INT 10h services.
>>>>>>
>>>>>> --- vgabios-0.6c/vgabios.c.orig    2013-01-20
>>>>>> 11:33:36.138548472 -0600 +++ vgabios-0.6c/vgabios.c
>>>>>> 2013-01-20 11:36:26.060270163 -0600 @@ -204,6 +204,7 @@
>>>>>> vgabios_website: .byte    0x00
>>>>>>
>>>>>>     #ifdef PCIBIOS
>>>>>> +.align 4 // DWORD alignment required by PCI Firmware
>>>>>> Specification vgabios_pci_data:
>>>>>>     .ascii "PCIR"
>>>>>>     #ifdef CIRRUS
>>>>>
>>>>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>>>>> possible to have this reviewed and commited?
>>>>
>>>> This change was commited to upstream vgabios back in February [1].
>>>
>>> But that has not resulted in it being brought into QEMU.
>>
>> Gerd, Anthony, care to update QEMU's vgabios repository [1] with
>> changes from upstream CVS repository [2]?
>>
>> [1] http://git.qemu.org/?p=vgabios.git
>> [2] http://cvs.savannah.gnu.org/viewvc/?root=vgabios
>
> Any comment?

ping.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Andreas Färber]

Am 09.10.2013 03:56, schrieb Brad Smith:
> On 25/09/13 7:24 PM, Brad Smith wrote:
>> On 21/09/13 12:38 PM, Sebastian Herbszt wrote:
>>> Brad Smith wrote:
>>>> On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
>>>>> Brad Smith wrote:
>>>>>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>>>>>> The PCI Firmware Specification apparently requires that the PCI
>>>>>>> Data Structure be DWORD-aligned. The implementation in OVMF also
>>>>>>> requires this, so vgabios ROMs don't work there. With this fixed,
>>>>>>> I can now initialise the VGA ROM from EFI, and EFI can display
>>>>>>> using INT 10h services.
>>>>>>>
>>>>>>> --- vgabios-0.6c/vgabios.c.orig    2013-01-20
>>>>>>> 11:33:36.138548472 -0600 +++ vgabios-0.6c/vgabios.c
>>>>>>> 2013-01-20 11:36:26.060270163 -0600 @@ -204,6 +204,7 @@
>>>>>>> vgabios_website: .byte    0x00
>>>>>>>
>>>>>>>     #ifdef PCIBIOS
>>>>>>> +.align 4 // DWORD alignment required by PCI Firmware
>>>>>>> Specification vgabios_pci_data:
>>>>>>>     .ascii "PCIR"
>>>>>>>     #ifdef CIRRUS
>>>>>>
>>>>>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>>>>>> possible to have this reviewed and commited?
>>>>>
>>>>> This change was commited to upstream vgabios back in February [1].
>>>>
>>>> But that has not resulted in it being brought into QEMU.
>>>
>>> Gerd, Anthony, care to update QEMU's vgabios repository [1] with
>>> changes from upstream CVS repository [2]?
>>>
>>> [1] http://git.qemu.org/?p=vgabios.git
>>> [2] http://cvs.savannah.gnu.org/viewvc/?root=vgabios
>>
>> Any comment?
> 
> ping.

Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to be
falling through the cracks...

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Sebastian Herbszt]

Andreas Färber wrote:
> Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to
> be falling through the cracks...
> 
> Andreas
>

Is this patch still required?
I was under the impression that no patch is needed for Win 8 after
reading the thread on SeaBIOS list.

Sebastian

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Gerd Hoffmann]

On Do, 2013-10-10 at 21:17 +0200, Sebastian Herbszt wrote:
> Andreas Färber wrote:
> > Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to
> > be falling through the cracks...
> > 
> > Andreas
> >
> 
> Is this patch still required?
> I was under the impression that no patch is needed for Win 8 after
> reading the thread on SeaBIOS list.

There are two implementations, the lgpl vgabios and the seavgabios.  The
prebuild roms in the qemu git repo are lgpl vgabios roms.  Probably I'll
go switch to seavgabios with the next major (non-stable-branch) seabios
update.

cheers,
  Gerd

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Brad Smith]

On 11/10/13 2:31 AM, Gerd Hoffmann wrote:
> On Do, 2013-10-10 at 21:17 +0200, Sebastian Herbszt wrote:
>> Andreas Färber wrote:
>>> Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to
>>> be falling through the cracks...
>>>
>>> Andreas
>>>
>>
>> Is this patch still required?
>> I was under the impression that no patch is needed for Win 8 after
>> reading the thread on SeaBIOS list.
>
> There are two implementations, the lgpl vgabios and the seavgabios.  The
> prebuild roms in the qemu git repo are lgpl vgabios roms.  Probably I'll
> go switch to seavgabios with the next major (non-stable-branch) seabios
> update.

When will that switch happen? Looking at the archive this proposal for 
switching to SeaVGABIOS has already been dragging on for a long time as 
it is.


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Gerd Hoffmann]

On So, 2013-11-24 at 15:35 -0500, Brad Smith wrote:
> On 11/10/13 2:31 AM, Gerd Hoffmann wrote:
> > On Do, 2013-10-10 at 21:17 +0200, Sebastian Herbszt wrote:
> >> Andreas Färber wrote:
> >>> Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to
> >>> be falling through the cracks...
> >>>
> >>> Andreas
> >>>
> >>
> >> Is this patch still required?
> >> I was under the impression that no patch is needed for Win 8 after
> >> reading the thread on SeaBIOS list.
> >
> > There are two implementations, the lgpl vgabios and the seavgabios.  The
> > prebuild roms in the qemu git repo are lgpl vgabios roms.  Probably I'll
> > go switch to seavgabios with the next major (non-stable-branch) seabios
> > update.
> 
> When will that switch happen? Looking at the archive this proposal for 
> switching to SeaVGABIOS has already been dragging on for a long time as 
> it is.

When the next seabios release is out, hopefully early in the 1.8 devel
cycle.

cheers,
  Gerd

[Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

The PCI Firmware Specification apparently requires that the PCI Data
Structure be DWORD-aligned. The implementation in OVMF also requires
this, so vgabios ROMs don't work there. With this fixed, I can now
initialise the VGA ROM from EFI, and EFI can display using INT 10h
services.

--- vgabios-0.6c/vgabios.c.orig	2013-01-20 11:33:36.138548472 -0600
+++ vgabios-0.6c/vgabios.c	2013-01-20 11:36:26.060270163 -0600
@@ -204,6 +204,7 @@ vgabios_website:
 .byte	0x00
 
 #ifdef PCIBIOS
+.align 4 // DWORD alignment required by PCI Firmware Specification
 vgabios_pci_data:
 .ascii "PCIR"
 #ifdef CIRRUS



-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation




[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Brad Smith]

On 20/01/13 1:12 PM, David Woodhouse wrote:
> The PCI Firmware Specification apparently requires that the PCI Data
> Structure be DWORD-aligned. The implementation in OVMF also requires
> this, so vgabios ROMs don't work there. With this fixed, I can now
> initialise the VGA ROM from EFI, and EFI can display using INT 10h
> services.
>
> --- vgabios-0.6c/vgabios.c.orig	2013-01-20 11:33:36.138548472 -0600
> +++ vgabios-0.6c/vgabios.c	2013-01-20 11:36:26.060270163 -0600
> @@ -204,6 +204,7 @@ vgabios_website:
>   .byte	0x00
>
>   #ifdef PCIBIOS
> +.align 4 // DWORD alignment required by PCI Firmware Specification
>   vgabios_pci_data:
>   .ascii "PCIR"
>   #ifdef CIRRUS

We have had this in the OpenBSD port of QEMU for awhile now. Is it 
possible to have this reviewed and commited?

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.