From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTqPY-0005V3-7p for qemu-devel@nongnu.org; Wed, 09 Oct 2013 05:50:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTqPR-0003ys-Nx for qemu-devel@nongnu.org; Wed, 09 Oct 2013 05:50:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTqPR-0003yo-Fi for qemu-devel@nongnu.org; Wed, 09 Oct 2013 05:50:25 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r999oJ4h005549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 9 Oct 2013 05:50:24 -0400 Message-ID: <525526D1.4020100@redhat.com> Date: Wed, 09 Oct 2013 11:50:09 +0200 From: Max Reitz MIME-Version: 1.0 References: <1381308268-23235-1-git-send-email-mreitz@redhat.com> <20131009094438.GG8994@dhcp-200-207.str.redhat.com> In-Reply-To: <20131009094438.GG8994@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: Free preallocated zero clusters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On 2013-10-09 11:44, Kevin Wolf wrote: > Am 09.10.2013 um 10:44 hat Max Reitz geschrieben: >> In qcow2_free_any_clusters, preallocated zero clusters should be freed >> just as normal clusters are. >> >> Signed-off-by: Max Reitz > Thanks, applied to the block branch. > > Do you have a test case that would cause a leak previously? > > Kevin Oh, right. qemu-img create -f qcow2 f.qcow2 64M qemu-io -c 'write 0 64M' -c 'write -z 0 64M' -c 'discard 0 64M' f.qcow2 qemu-img check f.qcow2 seems enough, I'll send that test case as a follow-up. Max