From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VTvXC-0005DM-W5
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 11:18:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VTvX8-0006lj-6z
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 11:18:46 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54518 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VTvX7-0006lU-UF
	for qemu-devel@nongnu.org; Wed, 09 Oct 2013 11:18:42 -0400
Message-ID: <525573CC.2000804@suse.de>
Date: Wed, 09 Oct 2013 17:18:36 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20130919185352.0000135e@unknown>
	<523CCF9D.1090002@comstyle.com>	<20130921183824.00002cd3@unknown>
	<524370C6.3010603@comstyle.com> <5254B7BA.1080402@comstyle.com>
In-Reply-To: <5254B7BA.1080402@comstyle.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brad Smith <brad@comstyle.com>, Sebastian Herbszt <herbszt@gmx.de>
Cc: Bo Yang <BoYang@suse.com>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org

Am 09.10.2013 03:56, schrieb Brad Smith:
> On 25/09/13 7:24 PM, Brad Smith wrote:
>> On 21/09/13 12:38 PM, Sebastian Herbszt wrote:
>>> Brad Smith wrote:
>>>> On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
>>>>> Brad Smith wrote:
>>>>>> On 20/01/13 1:12 PM, David Woodhouse wrote:
>>>>>>> The PCI Firmware Specification apparently requires that the PCI
>>>>>>> Data Structure be DWORD-aligned. The implementation in OVMF also
>>>>>>> requires this, so vgabios ROMs don't work there. With this fixed,
>>>>>>> I can now initialise the VGA ROM from EFI, and EFI can display
>>>>>>> using INT 10h services.
>>>>>>>
>>>>>>> --- vgabios-0.6c/vgabios.c.orig    2013-01-20
>>>>>>> 11:33:36.138548472 -0600 +++ vgabios-0.6c/vgabios.c
>>>>>>> 2013-01-20 11:36:26.060270163 -0600 @@ -204,6 +204,7 @@
>>>>>>> vgabios_website: .byte    0x00
>>>>>>>
>>>>>>>     #ifdef PCIBIOS
>>>>>>> +.align 4 // DWORD alignment required by PCI Firmware
>>>>>>> Specification vgabios_pci_data:
>>>>>>>     .ascii "PCIR"
>>>>>>>     #ifdef CIRRUS
>>>>>>
>>>>>> We have had this in the OpenBSD port of QEMU for awhile now. Is it
>>>>>> possible to have this reviewed and commited?
>>>>>
>>>>> This change was commited to upstream vgabios back in February [1].
>>>>
>>>> But that has not resulted in it being brought into QEMU.
>>>
>>> Gerd, Anthony, care to update QEMU's vgabios repository [1] with
>>> changes from upstream CVS repository [2]?
>>>
>>> [1] http://git.qemu.org/?p=3Dvgabios.git
>>> [2] http://cvs.savannah.gnu.org/viewvc/?root=3Dvgabios
>>
>> Any comment?
>=20
> ping.

Same for http://patchwork.ozlabs.org/patch/273758/ - vgabios seems to be
falling through the cracks...

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg