From: Hans de Goede <hdegoede@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events
Date: Wed, 09 Oct 2013 20:15:54 +0200 [thread overview]
Message-ID: <52559D5A.2030408@redhat.com> (raw)
In-Reply-To: <52559A8A.2070201@redhat.com>
Hi,
On 10/09/2013 08:03 PM, Hans de Goede wrote:
<snip>
> So I started looking for suspecious timers under audio/*.c and immediately
> found this in audio/audio.c :
>
> static void audio_reset_timer (AudioState *s)
> {
> if (audio_is_timer_needed ()) {
> timer_mod (s->ts, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 1);
> }
> else {
> timer_del (s->ts);
> }
> }
>
> static void audio_timer (void *opaque)
> {
> audio_run ("timer");
> audio_reset_timer (opaque);
> }
>
> Note how that is using a timer which expires every freaking nano second,
> I think it is very likely that is the culprit.
Yep, this is the culprit, patch coming up.
Regards,
Hans
next prev parent reply other threads:[~2013-10-09 18:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 19:10 [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events Hans de Goede
2013-10-08 19:13 ` Paolo Bonzini
2013-10-08 19:21 ` Hans de Goede
2013-10-08 19:33 ` Alex Bligh
2013-10-08 19:41 ` Hans de Goede
2013-10-08 20:01 ` Alex Bligh
2013-10-08 20:07 ` Alex Bligh
2013-10-08 20:16 ` Hans de Goede
2013-10-08 20:32 ` Alex Bligh
2013-10-08 20:50 ` Paolo Bonzini
2013-10-09 12:58 ` Hans de Goede
2013-10-09 13:18 ` Alex Bligh
2013-10-09 18:03 ` Hans de Goede
2013-10-09 18:15 ` Hans de Goede [this message]
2013-10-09 18:28 ` Alex Bligh
2013-10-09 18:36 ` Alex Bligh
2013-10-09 18:49 ` Hans de Goede
2013-10-09 19:03 ` Paolo Bonzini
2013-10-09 19:15 ` Hans de Goede
2013-10-09 14:37 ` Paolo Bonzini
2013-10-09 16:19 ` Alex Bligh
2013-10-09 16:26 ` Paolo Bonzini
2013-10-09 16:33 ` Alex Bligh
2013-10-09 17:53 ` Hans de Goede
2013-10-09 18:09 ` Hans de Goede
2013-10-08 19:48 ` Alex Bligh
2013-10-08 20:01 ` Hans de Goede
2013-10-08 21:25 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52559D5A.2030408@redhat.com \
--to=hdegoede@redhat.com \
--cc=alex@alex.org.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).