From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTz9t-0002lU-L7 for qemu-devel@nongnu.org; Wed, 09 Oct 2013 15:11:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTz9o-00065V-Ky for qemu-devel@nongnu.org; Wed, 09 Oct 2013 15:10:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTz9o-000659-4O for qemu-devel@nongnu.org; Wed, 09 Oct 2013 15:10:52 -0400 Message-ID: <5255AA38.6090807@redhat.com> Date: Wed, 09 Oct 2013 13:10:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381318130-10620-1-git-send-email-quintela@redhat.com> <1381318130-10620-9-git-send-email-quintela@redhat.com> In-Reply-To: <1381318130-10620-9-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sc9JIRA0Bu0QQbGWKFoI9bTXBgnWC9O4R" Subject: Re: [Qemu-devel] [PATCH 08/28] exec: simplify notdirty_mem_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sc9JIRA0Bu0QQbGWKFoI9bTXBgnWC9O4R Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/09/2013 05:28 AM, Juan Quintela wrote: > We don't need to make special things for CODE, just set the other two b= its >=20 > Signed-off-by: Juan Quintela > --- > exec.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) >=20 > - dirty_flags |=3D (0xff & ~CODE_DIRTY_FLAG); > - cpu_physical_memory_set_dirty_flags(ram_addr, dirty_flags); > + cpu_physical_memory_set_dirty_flag(ram_addr, MIGRATION_DIRTY_FLAG)= ; > + cpu_physical_memory_set_dirty_flag(ram_addr, VGA_DIRTY_FLAG); Worth writing as a single call: cpu_physical_memory_set_dirty_flag(ram_addr, MIGRATION_DIRTY_FLAG|VGA_DIRTY_FLAG); or will that just get in the way of refactoring later in the series? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sc9JIRA0Bu0QQbGWKFoI9bTXBgnWC9O4R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSVao4AAoJEKeha0olJ0Nq5qAH/i37psxOXJ7+stKh8bZC6ECv kI6OfGGITim/Sj5+RvkqXhmmcVCv3nymR2Y1c4Gnz7hFi8JpLnLcm74pS3/nLHsS qv4m6UaKHd/P8V3ZV5U+SjIKdGW/hy7guu77NP2csuVh5+qGNwgjZJl0xqWrzGQb MyqfLWoI+oSlRUXHPAk3d5OIAHwSTnJxxhKLldnFrJJZPIsUjMakaWBcjWcH7iWt hVoozrMm9YCOgOFLTYRU4V9hIqtLyMlaDU12rVyVEmzno7zcs7OqrQ1w20Y8xzmv MNOcM/D6SHaOOPngO1k3AOWHFIJm6RxD0TpBekk6TB9GISpde4xM7KGIi0scBJo= =TdLe -----END PGP SIGNATURE----- --sc9JIRA0Bu0QQbGWKFoI9bTXBgnWC9O4R--