From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTzHm-0006VB-EE for qemu-devel@nongnu.org; Wed, 09 Oct 2013 15:19:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTzHh-0000j7-Hb for qemu-devel@nongnu.org; Wed, 09 Oct 2013 15:19:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTzHh-0000ix-8Y for qemu-devel@nongnu.org; Wed, 09 Oct 2013 15:19:01 -0400 Message-ID: <5255AC22.4080904@redhat.com> Date: Wed, 09 Oct 2013 13:18:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381318130-10620-1-git-send-email-quintela@redhat.com> <1381318130-10620-9-git-send-email-quintela@redhat.com> <5255AA38.6090807@redhat.com> In-Reply-To: <5255AA38.6090807@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8sTi9WBSrvkUAAVmgLeRq10nMDtdrCVAb" Subject: Re: [Qemu-devel] [PATCH 08/28] exec: simplify notdirty_mem_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org, Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8sTi9WBSrvkUAAVmgLeRq10nMDtdrCVAb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/09/2013 01:10 PM, Eric Blake wrote: > On 10/09/2013 05:28 AM, Juan Quintela wrote: >> We don't need to make special things for CODE, just set the other two = bits >> >> Signed-off-by: Juan Quintela >> --- >> exec.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >=20 >> - dirty_flags |=3D (0xff & ~CODE_DIRTY_FLAG); >> - cpu_physical_memory_set_dirty_flags(ram_addr, dirty_flags); >> + cpu_physical_memory_set_dirty_flag(ram_addr, MIGRATION_DIRTY_FLAG= ); >> + cpu_physical_memory_set_dirty_flag(ram_addr, VGA_DIRTY_FLAG); >=20 > Worth writing as a single call: >=20 > cpu_physical_memory_set_dirty_flag(ram_addr, > MIGRATION_DIRTY_FLAG|VGA_DIRTY_FLAG); >=20 > or will that just get in the way of refactoring later in the series? Answering myself - it gets in the way. Doing things explicitly one flag at a time makes it easier to redirect flags to separate tables. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8sTi9WBSrvkUAAVmgLeRq10nMDtdrCVAb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSVawiAAoJEKeha0olJ0NqQaoH/RVyxlvBnlYMtZzOLUq98ho5 jH1vqXJLk92FKs1pU4B4mrNQn3TIXEjyoBA+YoUSInxwAAXFNjsjFRMMcdzexYPn n+o59hGqypPItIZs0amcUDwmZ/X+M1i5wumSGEChpgYxbsjQ2PyppyEb86HWrAXD sRtRK9zGPDNgtOCI+NgTPS6CJ5p/wn9zES5o7SoXSpgdtXjcs4rK0lHFdEsYJ2qp x2j7hd744YxbJl9t5V1L/uCQCDw1hq6SP6zQgCi31Aq0G2PyBGmMiMQz0HNrTXVn DNDa9noUwO7N7juBYc0aYI3LmY+bAVsx3gVBlm4b9uueXTKBtUcDy6jENbMN+04= =oQZ3 -----END PGP SIGNATURE----- --8sTi9WBSrvkUAAVmgLeRq10nMDtdrCVAb--