From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VU9Pc-0006KC-QW
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 02:08:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VU9PT-0005pU-Sq
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 02:07:52 -0400
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:36582)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VU9PT-0005p1-7Q
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 02:07:43 -0400
Received: from /spool/local
	by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Thu, 10 Oct 2013 11:37:40 +0530
Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61])
	by d28dlp01.in.ibm.com (Postfix) with ESMTP id 0EC3CE0056
	for <qemu-devel@nongnu.org>; Thu, 10 Oct 2013 11:38:58 +0530 (IST)
Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66])
	by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r9A67J7P31260676
	for <qemu-devel@nongnu.org>; Thu, 10 Oct 2013 11:37:20 +0530
Received: from d28av04.in.ibm.com (localhost [127.0.0.1])
	by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	r9A67LP7016311
	for <qemu-devel@nongnu.org>; Thu, 10 Oct 2013 11:37:21 +0530
Message-ID: <52564420.3010300@linux.vnet.ibm.com>
Date: Thu, 10 Oct 2013 14:07:28 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1380154568-5339-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1380154568-5339-6-git-send-email-xiawenc@linux.vnet.ibm.com>
	<524AF346.7090900@redhat.com>
In-Reply-To: <524AF346.7090900@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH V3 5/7] qemu-img: add -L for snapshot in
	convert
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org

于 2013/10/2 0:07, Paolo Bonzini 写道:
> Il 26/09/2013 02:16, Wenchao Xia ha scritto:
>> +        c = getopt(argc, argv, "f:O:B:s:hce6o:pS:t:qnL:");
>>           if (c == -1) {
>>               break;
>>           }
>> @@ -1183,6 +1184,9 @@ static int img_convert(int argc, char **argv)
>>           case 's':
>>               snapshot_name = optarg;
>>               break;
>> +        case 'L':
>> +            sn_opts = qemu_opts_parse(&internal_snapshot_opts, optarg, 0);
>> +            break;
>>           case 'S':
> Should qemu-img introduce -l too, and deprecate -s (continue to accept
> it silently, but not document it)?
>
> Paolo
>
OK, will document both but mark it deprecated.