From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VU9RW-00083t-03 for qemu-devel@nongnu.org; Thu, 10 Oct 2013 02:09:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VU9RN-00064j-2h for qemu-devel@nongnu.org; Thu, 10 Oct 2013 02:09:49 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:39974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VU9RM-00064O-Dc for qemu-devel@nongnu.org; Thu, 10 Oct 2013 02:09:41 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Oct 2013 11:39:38 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 03A1C394003F for ; Thu, 10 Oct 2013 11:39:18 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9A69XAE40828958 for ; Thu, 10 Oct 2013 11:39:34 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9A69ZRq023837 for ; Thu, 10 Oct 2013 11:39:35 +0530 Message-ID: <525644A6.5070607@linux.vnet.ibm.com> Date: Thu, 10 Oct 2013 14:09:42 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1380154568-5339-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1380154568-5339-7-git-send-email-xiawenc@linux.vnet.ibm.com> <524AE2BA.7090905@redhat.com> In-Reply-To: <524AE2BA.7090905@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 6/7] qemu-img: add doc for param -L in convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com 于 2013/10/1 22:56, Eric Blake 写道: > On 09/25/2013 06:16 PM, Wenchao Xia wrote: >> Also renamed snapshot_name to snapshot_id_or_name to tip better. > s/to tip better/as a better hint of what it does/ > >> Signed-off-by: Wenchao Xia >> --- >> qemu-img-cmds.hx | 2 +- >> qemu-img.c | 2 ++ >> qemu-img.texi | 7 +++++-- >> 3 files changed, 8 insertions(+), 3 deletions(-) > Squash this into 5/7. > OK. >> + " 'snapshot_param' is param used for internal snapshot, format is\n" >> + " 'snapshot.id=[ID],snapshot.name=[NAME]'\n" > Again, can you reuse the existing -s, instead of having to add -L, by There may be compatiability issue for existing user, I think add -l and deprecate old -s, would be better. > making the command line parser smarter about whether it is seeing a > single name vs. a string starting with 'snapshot.'? >