From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34198)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VUNEm-0004dG-TT
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 16:53:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VUNEe-0008Hm-Gk
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 16:53:36 -0400
Received: from mail-qe0-x231.google.com ([2607:f8b0:400d:c02::231]:48510)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VUNEe-0008Ha-C3
	for qemu-devel@nongnu.org; Thu, 10 Oct 2013 16:53:28 -0400
Received: by mail-qe0-f49.google.com with SMTP id ff1so2363909qeb.36
	for <qemu-devel@nongnu.org>; Thu, 10 Oct 2013 13:53:27 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <525713C3.7080405@twiddle.net>
Date: Thu, 10 Oct 2013 13:53:23 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1381417639-22547-1-git-send-email-pbonzini@redhat.com>
	<1381417639-22547-3-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1381417639-22547-3-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error
 exits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com

On 10/10/2013 08:07 AM, Paolo Bonzini wrote:
>      return head;
> +
> +out:
> +    assert(ret < 0);
> +    if (ret == -EFAULT) {
> +        vring->broken = true;
> +    }
> +    return ret;

If this is only the error path, can we call the
label something other than "out"?


r~