From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alex Bligh <alex@alex.org.uk>,
Corentin Chary <corentincj@iksaif.net>,
Jan Kiszka <jan.kiszka@siemens.com>,
Qemu-development List <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] Spelling fixes
Date: Fri, 11 Oct 2013 08:09:42 +0200 [thread overview]
Message-ID: <52579626.8020507@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA_KEnRRUCp87K55RanQWHXr2gPBvtk2uQc7hCwjo6S94g@mail.gmail.com>
Am 11.10.2013 03:34, schrieb Peter Maydell:
> On 11 October 2013 04:11, Stefan Weil <sw@weilnetz.de> wrote:
>> Am 08.07.2013 17:14, schrieb Corentin Chary:
>>> The comments (and most of the code) are from libvncserver (and,
>>> earlier, from "THE 'ZYWRLE' VNC CODEC SOURCE CODE. " as described in
>>> the header):
>>>
>>> http://fastdroid-vnc.googlecode.com/svn-history/r3/trunk/LibVNCServer-0.9.7/libvncserver/zywrletemplate.c
>>>
>> Then I suggest to apply my patch as it is. It fixes two locations and
>> improves a third one a little bit.
> Disagree. If we don't understand the intention of the original
> author we should leave the text as is rather than changing it
> in a way which might be incorrect.
>
> -- PMM
- This lead us to more speed and less memory.
- Of cause, the result of both method is quite same
- because it's only difference that coefficient position.
+ This leads us to more speed and less memory.
+ Of course, the result of both methods is quite same
+ because its only difference is that coefficient position.
Would you agree on fixing the first line only and removing the two following lines?
Stefan
next prev parent reply other threads:[~2013-10-11 6:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 20:25 [Qemu-devel] [PATCH] Spelling fixes Stefan Weil
2013-07-07 22:05 ` Alex Bligh
2013-07-07 22:32 ` Peter Maydell
2013-07-08 4:43 ` Stefan Weil
2013-07-08 15:14 ` Corentin Chary
2013-10-10 19:11 ` Stefan Weil
2013-10-11 1:34 ` Peter Maydell
2013-10-11 6:09 ` Stefan Weil [this message]
2013-10-11 18:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52579626.8020507@weilnetz.de \
--to=sw@weilnetz.de \
--cc=alex@alex.org.uk \
--cc=anthony@codemonkey.ws \
--cc=corentincj@iksaif.net \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).