From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error exits
Date: Fri, 11 Oct 2013 11:19:29 +0200 [thread overview]
Message-ID: <5257C2A1.2080506@redhat.com> (raw)
In-Reply-To: <525713C3.7080405@twiddle.net>
Il 10/10/2013 22:53, Richard Henderson ha scritto:
> On 10/10/2013 08:07 AM, Paolo Bonzini wrote:
>> return head;
>> +
>> +out:
>> + assert(ret < 0);
>> + if (ret == -EFAULT) {
>> + vring->broken = true;
>> + }
>> + return ret;
>
> If this is only the error path, can we call the
> label something other than "out"?
Yes. Though I think it does not matter if the function returns a zero
or positive result after the next patch, so it can become a general exit
label too.
Paolo
next prev parent reply other threads:[~2013-10-11 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 15:07 [Qemu-devel] [PATCH 0/4] dataplane: use more of the generic virtio data structures, drop hostmem Paolo Bonzini
2013-10-10 15:07 ` [Qemu-devel] [PATCH 1/4] vring: create a common function to parse descriptors Paolo Bonzini
2013-10-10 15:07 ` [Qemu-devel] [PATCH 2/4] vring: factor common code for error exits Paolo Bonzini
2013-10-10 20:53 ` Richard Henderson
2013-10-11 9:19 ` Paolo Bonzini [this message]
2013-10-10 15:07 ` [Qemu-devel] [PATCH 3/4] dataplane: change vring API to use VirtQueueElement Paolo Bonzini
2013-12-04 14:06 ` Stefan Hajnoczi
2013-12-04 17:40 ` Paolo Bonzini
2013-12-05 9:24 ` Stefan Hajnoczi
2013-12-05 10:34 ` Paolo Bonzini
2013-12-06 9:02 ` Stefan Hajnoczi
2013-10-10 15:07 ` [Qemu-devel] [PATCH 4/4] dataplane: replace hostmem with memory_region_find Paolo Bonzini
2013-12-04 14:12 ` [Qemu-devel] [PATCH 0/4] dataplane: use more of the generic virtio data structures, drop hostmem Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5257C2A1.2080506@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).