From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42763)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VUYsm-0007wn-DV
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 05:19:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VUYsg-0002gA-ET
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 05:19:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26301)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VUYsf-0002g6-Q6
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 05:19:34 -0400
Message-ID: <5257C2A1.2080506@redhat.com>
Date: Fri, 11 Oct 2013 11:19:29 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1381417639-22547-1-git-send-email-pbonzini@redhat.com>
	<1381417639-22547-3-git-send-email-pbonzini@redhat.com>
	<525713C3.7080405@twiddle.net>
In-Reply-To: <525713C3.7080405@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] vring: factor common code for error
 exits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

Il 10/10/2013 22:53, Richard Henderson ha scritto:
> On 10/10/2013 08:07 AM, Paolo Bonzini wrote:
>>      return head;
>> +
>> +out:
>> +    assert(ret < 0);
>> +    if (ret == -EFAULT) {
>> +        vring->broken = true;
>> +    }
>> +    return ret;
> 
> If this is only the error path, can we call the
> label something other than "out"?

Yes.  Though I think it does not matter if the function returns a zero
or positive result after the next patch, so it can become a general exit
label too.

Paolo