From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUbGl-0007AN-5F for qemu-devel@nongnu.org; Fri, 11 Oct 2013 07:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUbGg-0000ks-5k for qemu-devel@nongnu.org; Fri, 11 Oct 2013 07:52:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUbGf-0000kl-Ty for qemu-devel@nongnu.org; Fri, 11 Oct 2013 07:52:30 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9BBqS2P019716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Oct 2013 07:52:28 -0400 Message-ID: <5257E67C.5080008@redhat.com> Date: Fri, 11 Oct 2013 05:52:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381480281-14607-1-git-send-email-famz@redhat.com> <1381480281-14607-3-git-send-email-famz@redhat.com> In-Reply-To: <1381480281-14607-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FJ3E6AthgVdsBaOtR6MTLrlDvASPJQ2Al" Subject: Re: [Qemu-devel] [PATCH v2 2/2] vmdk: implment bdrv_get_specific_info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FJ3E6AthgVdsBaOtR6MTLrlDvASPJQ2Al Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/11/2013 02:31 AM, Fam Zheng wrote: > Implement .bdrv_get_specific_info to return the extent information. >=20 > Signed-off-by: Fam Zheng > --- > + > + *spec_info->vmdk =3D (ImageInfoSpecificVmdk) { > + .create_type =3D g_strdup(s->create_type), > + .cid =3D s->cid, > + }; > + > =20 > ## > +# @ImageInfoSpecificVmdk: > +# > +# @create_type: The create type of VMDK image Is it worth making this an enum type rather than an open-coded string? But that's not a show-stopper to me. > +# > +# @cid: Content id of image > +# > +# @parent-cid: Parent VMDK image's cid > +# > +# @extents: List of extent files > +# > +# Since: 1.7 > +## > +{ 'type': 'ImageInfoSpecificVmdk', > + 'data': { > + 'create_type': 'str', > + 'cid': 'int', > + 'parent-cid': 'int', > + 'extents': ['ImageInfo'] > + } } Both patches look fine from the QMP point of view; I didn't closely review the matching C code for accuracy though. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FJ3E6AthgVdsBaOtR6MTLrlDvASPJQ2Al Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSV+Z8AAoJEKeha0olJ0Nq/g8H/iqPtrIMC/hhx7Iikhmupb3o AiAt1V6WvLy4eyNGflC4KYr1ACwQNcIIeld0TdGCK83k9a4T+4IvWRVUNDLEpa9Q bcwrUIHx30rpMIEz0wvjS/o994ffGiAAugU43A9IQIeWXOqGVXRPZJuLGpWyKJZ4 XXZO298Gie+pvmioea6W1BBlsK1qC0h9cPDJ14cmDzlHE1oQM1nLTDH6ilDbuGyL 9w1wSziidV7ppV1e8hb+fuPRnwZw5r2GAnIxEGxXi6SUqrt9NYAAPP8FgbOUZFxO utOLbv1L65aY5tEHH3Aa/T11Vh9rvvrpKDmyV7sKy8NjWje2IXJsTRvp4su18mg= =+ooT -----END PGP SIGNATURE----- --FJ3E6AthgVdsBaOtR6MTLrlDvASPJQ2Al--