From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open
Date: Fri, 11 Oct 2013 06:42:31 -0600 [thread overview]
Message-ID: <5257F237.3010305@redhat.com> (raw)
In-Reply-To: <1381494616-1544-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On 10/11/2013 06:30 AM, Max Reitz wrote:
> On one occasion, hdev_open() returned -1 in case of an unknown error
> instead of a proper -errno value. Adjust this to match the behavior of
> raw_open() (in raw-win32), which is to return -EINVAL in this case.
> Also, change the call to error_setg*() to match the one in raw_open() as
> well.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Follow-up to (as suggested by Eric):
> - block/raw-win32: Employ error parameter
> (3/5 from the "block: Employ error parameter" series)
> ---
> block/raw-win32.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-11 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 12:30 [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open Max Reitz
2013-10-11 12:42 ` Eric Blake [this message]
2013-10-17 12:55 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5257F237.3010305@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).