From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUc3D-0003nc-B8 for qemu-devel@nongnu.org; Fri, 11 Oct 2013 08:42:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUc38-0001FI-Bg for qemu-devel@nongnu.org; Fri, 11 Oct 2013 08:42:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUc38-0001FC-3K for qemu-devel@nongnu.org; Fri, 11 Oct 2013 08:42:34 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9BCgWQm016261 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Oct 2013 08:42:32 -0400 Message-ID: <5257F237.3010305@redhat.com> Date: Fri, 11 Oct 2013 06:42:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381494616-1544-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1381494616-1544-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LG1CXG9TcPcBrSrdFTPlwjTq6AD1A0L0v" Subject: Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LG1CXG9TcPcBrSrdFTPlwjTq6AD1A0L0v Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/11/2013 06:30 AM, Max Reitz wrote: > On one occasion, hdev_open() returned -1 in case of an unknown error > instead of a proper -errno value. Adjust this to match the behavior of > raw_open() (in raw-win32), which is to return -EINVAL in this case. > Also, change the call to error_setg*() to match the one in raw_open() a= s > well. >=20 > Signed-off-by: Max Reitz > --- > Follow-up to (as suggested by Eric): > - block/raw-win32: Employ error parameter > (3/5 from the "block: Employ error parameter" series) > --- > block/raw-win32.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LG1CXG9TcPcBrSrdFTPlwjTq6AD1A0L0v Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSV/I3AAoJEKeha0olJ0NqcAEIAJLUmLwYAwAYcSrWI2jb4Znf EXBMqpj5WTb/5dj65DPswV8syhDu3j/CK7UZW7Jw20JgyrbjKzs6lTCILIFDLMRJ oJK4U3h+5QkMgl6AH9DcijuolmbDUmZeUpvJ0oPHpyHrRLO9MGDyH0o//xiWG/UF 2Q9C+wzXlvn5rl0+gdkrMOUMMUPsjdfQfvSnq9vtpz60TaRCjyKUQhlAeh0DTVjL m+E5L5cklYYGI5YiWO7mzjmsrm7AmLdqv5nA6k4oFd5/NoHTFqnaCybGJinTRahy jiMwYWaFWR4uSOjLrduHbiNFb48ZBnpNlhghxIJfgDjwN0Rd0vJlz70uqnowDZY= =A+MO -----END PGP SIGNATURE----- --LG1CXG9TcPcBrSrdFTPlwjTq6AD1A0L0v--