From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUey0-0003c3-R8 for qemu-devel@nongnu.org; Fri, 11 Oct 2013 11:49:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUexu-0001qs-SP for qemu-devel@nongnu.org; Fri, 11 Oct 2013 11:49:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUexu-0001ql-Kd for qemu-devel@nongnu.org; Fri, 11 Oct 2013 11:49:22 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9BFnL5S014807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Oct 2013 11:49:21 -0400 Message-ID: <52581E00.8080403@redhat.com> Date: Fri, 11 Oct 2013 11:49:20 -0400 From: Cole Robinson MIME-Version: 1.0 References: <87y560tjmj.fsf@blackfin.pond.sub.org> In-Reply-To: <87y560tjmj.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On 10/11/2013 02:19 AM, Markus Armbruster wrote: > Cole Robinson writes: > >> Using multiple calls to error_report here means every line is >> prefaced with the (potentially long) pci-assign command line >> arguments. Use a single error_report to preserve the intended >> formatting. > > The orthodox way to do this is to use error_report() for the > (single-line!) error message, then error_printf() for additional > information. See commit 2da2e52..312fd5f for an example. > Sounds good. This code path is always preceded by an error_report() call, we can just change this massive message to error_printf(). - Cole