From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUhge-0005av-0f for qemu-devel@nongnu.org; Fri, 11 Oct 2013 14:43:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUhgZ-0007I5-KI for qemu-devel@nongnu.org; Fri, 11 Oct 2013 14:43:43 -0400 Message-ID: <525846CC.10600@reactos.org> Date: Fri, 11 Oct 2013 20:43:24 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1381488828-22575-1-git-send-email-mark.cave-ayland@ilande.co.uk> In-Reply-To: <1381488828-22575-1-git-send-email-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] PPC: fix PCI configuration space MemoryRegions for grackle/uninorth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: Alexander Graf , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6Ry?= =?UTF-8?B?YmVy?= Mark Cave-Ayland a =C3=A9crit : > OpenBIOS prior to SVN r1225 had a horrible bug when accessing PCI > configuration space for PPC Mac architectures - instead of writing the = PCI > configuration data value to the data register address, it would instead= write > it to the data register address plus the PCI configuration address. >=20 > For this reason, the MemoryRegions for the PCI data register for > grackle/uninorth were extremely large in order to accomodate the entire= PCI > configuration space being accessed during OpenBIOS PCI bus enumeration.= Now > that the OpenBIOS images have been updated, reduce the MemoryRegion siz= es down > to a single 32-bit register as intended. >=20 > Signed-off-by: Mark Cave-Ayland > CC: Herv=C3=A9 Poussineau > CC: Andreas F=C3=A4rber > CC: Alexander Graf Tested-by: Herv=C3=A9 Poussineau