From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Alex Bligh <alex@alex.org.uk>, qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments
Date: Fri, 11 Oct 2013 21:28:22 +0200 [thread overview]
Message-ID: <52585156.1010707@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA9Stuakd5tytT_65j4mUtKUyXtGQAG3Htvei0k3HU5WWA@mail.gmail.com>
Am 11.10.2013 21:12, schrieb Peter Maydell:
> On 12 October 2013 04:06, Stefan Weil <sw@weilnetz.de> wrote:
>> * it's -> its
>> * Grammar fix in ui/vnc-enc-zywrle.h. In the same context
>> a sentence with unclear meaning which could not be fixed was removed.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>
>> This is an update of patch http://patchwork.ozlabs.org/patch/257416/
>> (Spelling fixes).
>>
>> v2: Don't try to fix a strange sentence in ui/vnc-enc-zywrle.h - remove it.
> What? I thought you meant "remove that part of the change from
> the patch", not "remove the sentence altogether". Please leave
> it in place so that anybody in future who needs to try to understand
> this code has the maximum available amount of clues.
>
> -- PMM
Well, I said "Would you agree on fixing the first line only and removing the two following lines?".
Obviously it's not so easy for foreign speakers like me to find the right words. :-)
I'll send a v3.
Stefan
prev parent reply other threads:[~2013-10-11 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 19:06 [Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments Stefan Weil
2013-10-11 19:12 ` Peter Maydell
2013-10-11 19:28 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52585156.1010707@weilnetz.de \
--to=sw@weilnetz.de \
--cc=alex@alex.org.uk \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).