[Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments

[Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments

[Stefan Weil]

* it's -> its
* Grammar fix in ui/vnc-enc-zywrle.h. In the same context
  a sentence with unclear meaning which could not be fixed was removed.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

This is an update of patch http://patchwork.ozlabs.org/patch/257416/
(Spelling fixes).

v2: Don't try to fix a strange sentence in ui/vnc-enc-zywrle.h - remove it.

 qapi-schema.json    |    2 +-
 slirp/if.c          |    2 +-
 ui/vnc-enc-zywrle.h |    4 +---
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index 145eca8..ce38a3a 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1864,7 +1864,7 @@
 #
 # Since: 0.14.0
 #
-# Notes: This command only exists as a stop-gap.  It's use is highly
+# Notes: This command only exists as a stop-gap.  Its use is highly
 #        discouraged.  The semantics of this command are not guaranteed.
 #
 #        Known limitations:
diff --git a/slirp/if.c b/slirp/if.c
index 87ca8a5..fb7acf8 100644
--- a/slirp/if.c
+++ b/slirp/if.c
@@ -142,7 +142,7 @@ diddit:
 
 /*
  * Send a packet
- * We choose a packet based on it's position in the output queues;
+ * We choose a packet based on its position in the output queues;
  * If there are packets on the fastq, they are sent FIFO, before
  * everything else.  Otherwise we choose the first packet from the
  * batchq and send it.  the next packet chosen will be from the session
diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h
index 1ff40b1..91d2616 100644
--- a/ui/vnc-enc-zywrle.h
+++ b/ui/vnc-enc-zywrle.h
@@ -305,9 +305,7 @@ static inline void harr(int8_t *px0, int8_t *px1)
    |L1H0H1H0|L1H0H1H0|L1H0H1H0|L1H0H1H0| : level 1
 
  In this method, H/L and X0/X1 is always same position.
- This lead us to more speed and less memory.
- Of cause, the result of both method is quite same
- because it's only difference that coefficient position.
+ This leads us to more speed and less memory.
 */
 static inline void wavelet_level(int *data, int size, int l, int skip_pixel)
 {
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments

[Peter Maydell]

On 12 October 2013 04:06, Stefan Weil <sw@weilnetz.de> wrote:
> * it's -> its
> * Grammar fix in ui/vnc-enc-zywrle.h. In the same context
>   a sentence with unclear meaning which could not be fixed was removed.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This is an update of patch http://patchwork.ozlabs.org/patch/257416/
> (Spelling fixes).
>
> v2: Don't try to fix a strange sentence in ui/vnc-enc-zywrle.h - remove it.

What? I thought you meant "remove that part of the change from
the patch", not "remove the sentence altogether". Please leave
it in place so that anybody in future who needs to try to understand
this code has the maximum available amount of clues.

-- PMM

Re: [Qemu-devel] [PATCH v2] misc: Spelling and other fixes in comments

[Stefan Weil]

Am 11.10.2013 21:12, schrieb Peter Maydell:
> On 12 October 2013 04:06, Stefan Weil <sw@weilnetz.de> wrote:
>> * it's -> its
>> * Grammar fix in ui/vnc-enc-zywrle.h. In the same context
>>   a sentence with unclear meaning which could not be fixed was removed.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>
>> This is an update of patch http://patchwork.ozlabs.org/patch/257416/
>> (Spelling fixes).
>>
>> v2: Don't try to fix a strange sentence in ui/vnc-enc-zywrle.h - remove it.
> What? I thought you meant "remove that part of the change from
> the patch", not "remove the sentence altogether". Please leave
> it in place so that anybody in future who needs to try to understand
> this code has the maximum available amount of clues.
>
> -- PMM

Well, I said "Would you agree on fixing the first line only and removing the two following lines?".
Obviously it's not so easy for foreign speakers like me to find the right words. :-)

I'll send a v3.

Stefan