From: Don Koch <dkoch@verizon.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Stefan Hajnoczi <stefanha@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments
Date: Fri, 11 Oct 2013 16:03:15 -0400 [thread overview]
Message-ID: <52585983.1000606@terremark.com> (raw)
In-Reply-To: <1381520073-32674-1-git-send-email-sw@weilnetz.de>
On 10/11/2013 03:34 PM, Stefan Weil wrote:
> * it's -> its
> * grammar fix in ui/vnc-enc-zywrle.h
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>
> v3:
> Don't try to improve a strange sentence in the same context ("Of cause [...]").
>
> qapi-schema.json | 2 +-
> slirp/if.c | 2 +-
> ui/vnc-enc-zywrle.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 60f3fd1..a003aa1 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1914,7 +1914,7 @@
> #
> # Since: 0.14.0
> #
> -# Notes: This command only exists as a stop-gap. It's use is highly
> +# Notes: This command only exists as a stop-gap. Its use is highly
> # discouraged. The semantics of this command are not guaranteed.
> #
> # Known limitations:
> diff --git a/slirp/if.c b/slirp/if.c
> index 87ca8a5..fb7acf8 100644
> --- a/slirp/if.c
> +++ b/slirp/if.c
> @@ -142,7 +142,7 @@ diddit:
>
> /*
> * Send a packet
> - * We choose a packet based on it's position in the output queues;
> + * We choose a packet based on its position in the output queues;
> * If there are packets on the fastq, they are sent FIFO, before
> * everything else. Otherwise we choose the first packet from the
> * batchq and send it. the next packet chosen will be from the session
> diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h
> index 1ff40b1..d436d58 100644
> --- a/ui/vnc-enc-zywrle.h
> +++ b/ui/vnc-enc-zywrle.h
> @@ -305,7 +305,7 @@ static inline void harr(int8_t *px0, int8_t *px1)
> |L1H0H1H0|L1H0H1H0|L1H0H1H0|L1H0H1H0| : level 1
>
> In this method, H/L and X0/X1 is always same position.
> - This lead us to more speed and less memory.
> + This leads us to more speed and less memory.
> Of cause, the result of both method is quite same
> because it's only difference that coefficient position.
> */
>
Since you're in the neighborhood, this paragraph needs more fixes:
In this method, H/L and X0/X1 is always in the same position.
This leads us to more speed and less memory.
Of course, the result of both methods is the same
because the only difference is the coefficient position.
Thanks,
-d
next prev parent reply other threads:[~2013-10-11 20:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 19:34 [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments Stefan Weil
2013-10-11 20:03 ` Don Koch [this message]
2013-10-11 20:08 ` Stefan Weil
2013-10-11 20:51 ` Don Koch
2013-10-11 20:09 ` Eric Blake
2013-10-11 20:10 ` Peter Maydell
2013-10-11 20:28 ` Don Koch
2013-10-21 8:46 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-10-23 5:37 ` Stefan Weil
2013-10-11 20:11 ` [Qemu-devel] " Peter Maydell
2013-10-26 9:08 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52585983.1000606@terremark.com \
--to=dkoch@verizon.com \
--cc=agraf@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).