From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36618)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dkoch@verizon.com>) id 1VUjMF-0002Ge-Uo
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 16:30:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dkoch@verizon.com>) id 1VUjMA-0005Zw-N0
	for qemu-devel@nongnu.org; Fri, 11 Oct 2013 16:30:47 -0400
Message-ID: <52585F8B.6080604@cloudswitch.com>
Date: Fri, 11 Oct 2013 16:28:59 -0400
From: Don Koch <dkoch@cloudswitch.com>
MIME-Version: 1.0
References: <1381520073-32674-1-git-send-email-sw@weilnetz.de>
	<52585983.1000606@terremark.com>
	<CAFEAcA8QMiNuBMN0=DmXA8RqV9iVdoD-weGF04njKCGw1nbbyg@mail.gmail.com>
In-Reply-To: <CAFEAcA8QMiNuBMN0=DmXA8RqV9iVdoD-weGF04njKCGw1nbbyg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in
	comments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-trivial <qemu-trivial@nongnu.org>, Stefan Weil <sw@weilnetz.de>, qemu-devel <qemu-devel@nongnu.org>, Don Koch <dkoch@verizon.com>, Alexander Graf <agraf@suse.de>, Stefan Hajnoczi <stefanha@redhat.com>, Richard Henderson <rth@twiddle.net>

On 10/11/2013 04:10 PM, Peter Maydell wrote:
> On 12 October 2013 05:03, Don Koch <dkoch@verizon.com> wrote:
>> On 10/11/2013 03:34 PM, Stefan Weil wrote:
>>> * it's -> its
>>> * grammar fix in ui/vnc-enc-zywrle.h
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>> ---
>>>
>>> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>>>
>>> v3:
>>> Don't try to improve a strange sentence in the same context ("Of cause [...]").
> 
>>>   In this method, H/L and X0/X1 is always same position.
>>> - This lead us to more speed and less memory.
>>> + This leads us to more speed and less memory.
>>>   Of cause, the result of both method is quite same
>>>   because it's only difference that coefficient position.
>>>  */
>>>
>>
>> Since you're in the neighborhood, this paragraph needs more fixes:
> 
> No, see the note above and the previous discussion.

In that case, there in no point in fixing just the lead/leads typo.

>>  In this method, H/L and X0/X1 is always in the same position.
>>  This leads us to more speed and less memory.
>>  Of course, the result of both methods is the same
>>  because the only difference is the coefficient position.
> 
> Unless you want to say you've reviewed the code and
> are completely confident that the original author meant
> "the same" or "exactly the same" and not "quite similar"
> then we need to leave the original wording alone.
> 
> -- PMM
> 

-d