From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VUjiA-0001C9-Lr for qemu-devel@nongnu.org; Fri, 11 Oct 2013 16:53:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VUji5-0004Jk-G8 for qemu-devel@nongnu.org; Fri, 11 Oct 2013 16:53:26 -0400 Message-ID: <525864C7.3040604@cloudswitch.com> Date: Fri, 11 Oct 2013 16:51:19 -0400 From: Don Koch MIME-Version: 1.0 References: <1381520073-32674-1-git-send-email-sw@weilnetz.de> <52585983.1000606@terremark.com> <52585AD0.9090105@weilnetz.de> In-Reply-To: <52585AD0.9090105@weilnetz.de> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Kevin Wolf , qemu-trivial , qemu-devel , Don Koch , Alexander Graf , Stefan Hajnoczi , Richard Henderson On 10/11/2013 04:08 PM, Stefan Weil wrote: > Am 11.10.2013 22:03, schrieb Don Koch: >> On 10/11/2013 03:34 PM, Stefan Weil wrote: >>> * it's -> its >>> * grammar fix in ui/vnc-enc-zywrle.h >>> >>> Signed-off-by: Stefan Weil >>> --- >>> >>> This is v3 of http://patchwork.ozlabs.org/patch/257416/. >>> >>> v3: >>> Don't try to improve a strange sentence in the same context ("Of cause [...]"). >>> >>> qapi-schema.json | 2 +- >>> slirp/if.c | 2 +- >>> ui/vnc-enc-zywrle.h | 2 +- >>> 3 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/qapi-schema.json b/qapi-schema.json >>> index 60f3fd1..a003aa1 100644 >>> --- a/qapi-schema.json >>> +++ b/qapi-schema.json >>> @@ -1914,7 +1914,7 @@ >>> # >>> # Since: 0.14.0 >>> # >>> -# Notes: This command only exists as a stop-gap. It's use is highly >>> +# Notes: This command only exists as a stop-gap. Its use is highly >>> # discouraged. The semantics of this command are not guaranteed. >>> # >>> # Known limitations: >>> diff --git a/slirp/if.c b/slirp/if.c >>> index 87ca8a5..fb7acf8 100644 >>> --- a/slirp/if.c >>> +++ b/slirp/if.c >>> @@ -142,7 +142,7 @@ diddit: >>> >>> /* >>> * Send a packet >>> - * We choose a packet based on it's position in the output queues; >>> + * We choose a packet based on its position in the output queues; >>> * If there are packets on the fastq, they are sent FIFO, before >>> * everything else. Otherwise we choose the first packet from the >>> * batchq and send it. the next packet chosen will be from the session >>> diff --git a/ui/vnc-enc-zywrle.h b/ui/vnc-enc-zywrle.h >>> index 1ff40b1..d436d58 100644 >>> --- a/ui/vnc-enc-zywrle.h >>> +++ b/ui/vnc-enc-zywrle.h >>> @@ -305,7 +305,7 @@ static inline void harr(int8_t *px0, int8_t *px1) >>> |L1H0H1H0|L1H0H1H0|L1H0H1H0|L1H0H1H0| : level 1 >>> >>> In this method, H/L and X0/X1 is always same position. >>> - This lead us to more speed and less memory. >>> + This leads us to more speed and less memory. >>> Of cause, the result of both method is quite same >>> because it's only difference that coefficient position. >>> */ >>> >> Since you're in the neighborhood, this paragraph needs more fixes: >> >> In this method, H/L and X0/X1 is always in the same position. > > Shouldn't it be "are always"? :-) Yes. I got swamped by the other typos. :-) > >> This leads us to more speed and less memory. >> Of course, the result of both methods is the same >> because the only difference is the coefficient position. >> >> Thanks, >> -d > > Maybe. Please let us fix that in a later patch.\ Works for me. > See also the previous discussion > (http://patchwork.ozlabs.org/patch/257416/). I had unfortunately deleted that thread when I saw there was an update. *sigh* > Regards, > Stefan Reviewed-By: Don Koch -d