From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: create fsdev/ directory
Date: Sun, 13 Oct 2013 09:01:41 +0200 [thread overview]
Message-ID: <525A4555.5000401@redhat.com> (raw)
In-Reply-To: <52599D8B.3020200@msgid.tls.msk.ru>
Il 12/10/2013 21:05, Michael Tokarev ha scritto:
> I considered doing it there initially, but decided to add it
> to the other place, because that's where virtfs variable
> is set. The place you're referring to will need to have a
> condition `if' based on $virtfs value.
It's harmless to create a directory that won't be used.
> Also, there are other places below this virtfs test (which I
> modified) which runs mkdir (dtc, pixman), so this is not
> something unusual.
I didn't check the code, and dtc+pixman are both submodules so there may
be something special there. But in general, let's avoid the "it's bad
so it's okay to make it worse" argument.
Paolo
prev parent reply other threads:[~2013-10-13 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 9:05 [Qemu-devel] [PATCH] configure: create fsdev/ directory Michael Tokarev
2013-10-12 12:54 ` Alex Bennée
2013-10-12 16:28 ` Paolo Bonzini
2013-10-12 19:05 ` Michael Tokarev
2013-10-13 7:01 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525A4555.5000401@redhat.com \
--to=pbonzini@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).