From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVFgn-0005Dg-Vw for qemu-devel@nongnu.org; Sun, 13 Oct 2013 03:02:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVFgf-0003Pj-Ca for qemu-devel@nongnu.org; Sun, 13 Oct 2013 03:02:09 -0400 Sender: Paolo Bonzini Message-ID: <525A4555.5000401@redhat.com> Date: Sun, 13 Oct 2013 09:01:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1381482317-25433-1-git-send-email-mjt@msgid.tls.msk.ru> <525978C8.9010002@redhat.com> <52599D8B.3020200@msgid.tls.msk.ru> In-Reply-To: <52599D8B.3020200@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: create fsdev/ directory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Il 12/10/2013 21:05, Michael Tokarev ha scritto: > I considered doing it there initially, but decided to add it > to the other place, because that's where virtfs variable > is set. The place you're referring to will need to have a > condition `if' based on $virtfs value. It's harmless to create a directory that won't be used. > Also, there are other places below this virtfs test (which I > modified) which runs mkdir (dtc, pixman), so this is not > something unusual. I didn't check the code, and dtc+pixman are both submodules so there may be something special there. But in general, let's avoid the "it's bad so it's okay to make it worse" argument. Paolo