From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVctI-0000ob-HI for qemu-devel@nongnu.org; Mon, 14 Oct 2013 03:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVct9-0006qL-Ix for qemu-devel@nongnu.org; Mon, 14 Oct 2013 03:48:36 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:53582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVct9-0006ni-00 for qemu-devel@nongnu.org; Mon, 14 Oct 2013 03:48:27 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 Oct 2013 13:18:17 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 15C52394004E for ; Mon, 14 Oct 2013 13:17:55 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9E7mBcB38011118 for ; Mon, 14 Oct 2013 13:18:11 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9E7mDgP026104 for ; Mon, 14 Oct 2013 13:18:13 +0530 Message-ID: <525BA1BB.1090006@linux.vnet.ibm.com> Date: Mon, 14 Oct 2013 15:48:11 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1378695482-29805-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1378695482-29805-8-git-send-email-xiawenc@linux.vnet.ibm.com> <5249FB21.7000405@redhat.com> In-Reply-To: <5249FB21.7000405@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for qcow2 snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com 于 2013/10/1 6:28, Eric Blake 写道: > On 09/08/2013 08:58 PM, Wenchao Xia wrote: >> This test will focus on the low level procedure of qcow2 snapshot >> operations, now it covers only the create operation. Overlap error >> paths are not checked since no good way to trigger those errors. >> >> Signed-off-by: Wenchao Xia >> --- >> tests/qemu-iotests/063 | 229 ++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/063.out | 37 +++++++ >> tests/qemu-iotests/group | 1 + >> 3 files changed, 267 insertions(+), 0 deletions(-) >> create mode 100755 tests/qemu-iotests/063 >> create mode 100644 tests/qemu-iotests/063.out >> >> +# only test qcow2 >> +_supported_fmt qcow2 >> +_supported_proto generic >> +_supported_os Linux >> + >> +IMGOPTS="compat=1.1" >> + >> +CLUSTER_SIZE=65536 >> + >> +SIZE=1G >> + >> +BLKDBG_TEST_IMG="blkdebug:$TEST_DIR/blkdebug.conf:$TEST_IMG" >> + >> +errno=5 > Not all platforms have errno 5 tied to EIO; but then again, you filtered > this test to run only on Linux. Is it possible to be a bit more > generic, though? > I think the test can be made more generic, but it is a bit hard for me to find out what number should be used on all platform now. Instead, I'd like to add a comments here:"bind the errno correctly if you want run this case on other platform". > At any rate, more tests are always good. I didn't read very closely; > but I also didn't see anything obviously wrong with the patch, and it is > self-validating whether the testsuite still passes after applying it. > So feel free to add: > > Reviewed-by: Eric Blake >