From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVuwk-0005qI-MP for qemu-devel@nongnu.org; Mon, 14 Oct 2013 23:05:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVuwd-0001Rk-02 for qemu-devel@nongnu.org; Mon, 14 Oct 2013 23:05:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVuwc-0001Rb-MY for qemu-devel@nongnu.org; Mon, 14 Oct 2013 23:05:14 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9F35Dm5019850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Oct 2013 23:05:13 -0400 Message-ID: <525CB0E7.8000707@redhat.com> Date: Mon, 14 Oct 2013 21:05:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381803804-4551-1-git-send-email-famz@redhat.com> In-Reply-To: <1381803804-4551-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NlDPJHsxxl0HIoVxdUdBwge7SW6ppdBhD" Subject: Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NlDPJHsxxl0HIoVxdUdBwge7SW6ppdBhD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/14/2013 08:23 PM, Fam Zheng wrote: > There is errp passed in, so no need for local_err and error_propagate. > Also drop the backing_filename which is set but unused since 34b5d2c. >=20 > Signed-off-by: Fam Zheng >=20 > -- Three dashes instead of two before 'git am' will notice that the rest of the comment is mail-only. > v2: fix typo in subject line. > drop backing_filename. > (Thanks Eric) >=20 > Signed-off-by: Fam Zheng > --- > block/mirror.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NlDPJHsxxl0HIoVxdUdBwge7SW6ppdBhD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSXLDoAAoJEKeha0olJ0Nq76EH/RQkNDxNUX1ogZSRbYIrxtxJ uI1Q/jLNprUI22Y4P41h8HH2j9rgK6xHwKXD2ifIFEuG55EOcBvwfUwFlSgD0+MF aHcha2MMOM7z5RnHSX5xPjObkH6lU51mQD4Myj2PRlcmAFO1EFeezfEYSagcw6Ay VZjIV6PZWGDSnjHi7D1dZ1SOaoCszdJJJSIZmryTmcgbX10biXvq4RVgDTxyaW8k VHyjnFKLQSUMjY2JMXfjWTT9v6A+3hO2cceiEjoE36pc/7uAMyBGwDWeZO0mZBUA dHiS7eyL+59malT/+DoOm5/LmRnZfPQsn6hb6lp4xyFOaCvVz4sBhNyZ64u3eQA= =wVys -----END PGP SIGNATURE----- --NlDPJHsxxl0HIoVxdUdBwge7SW6ppdBhD--