From: Eric Blake <eblake@redhat.com>
To: Stefan Weil <sw@weilnetz.de>,
Mike Qiu <qiudayu@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Cc: stefanha@redhat.com, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic
Date: Tue, 15 Oct 2013 06:36:01 -0600 [thread overview]
Message-ID: <525D36B1.3050208@redhat.com> (raw)
In-Reply-To: <525CCD98.7010707@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On 10/14/2013 11:07 PM, Stefan Weil wrote:
>
> Is it reasonable to get a random mac address in your guest? I don't
> think so. It would no longer be possible to connect to a guest using
> ssh, restart that guest and connect again with ssh.
Agreed - libvirt ALWAYS passes a MAC to qemu, even if the user did not
specify a MAC to libvirt, precisely because the MAC must be reproducible
rather than random to avoid changing the guest ABI. I don't think this
patch is needed - it's up to management to use qemu correctly.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-15 12:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 4:17 [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic Mike Qiu
2013-10-15 5:07 ` Stefan Weil
2013-10-15 5:57 ` mike
2013-10-15 6:05 ` Stefan Weil
2013-10-15 8:23 ` mike
2013-10-15 12:36 ` Eric Blake [this message]
2013-10-15 13:33 ` mike
2013-10-17 12:30 ` Stefan Hajnoczi
2013-10-18 2:54 ` mike
2013-10-18 9:00 ` Stefan Hajnoczi
2013-10-18 9:44 ` mike
2013-10-18 10:43 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2013-10-14 7:30 Mike Qiu
2013-10-14 7:32 ` mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525D36B1.3050208@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=qemu-devel@nongnu.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).