From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW3rA-0002KV-Ld for qemu-devel@nongnu.org; Tue, 15 Oct 2013 08:36:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VW3r5-0004tH-Qw for qemu-devel@nongnu.org; Tue, 15 Oct 2013 08:36:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW3r5-0004tD-Hw for qemu-devel@nongnu.org; Tue, 15 Oct 2013 08:36:07 -0400 Message-ID: <525D36B1.3050208@redhat.com> Date: Tue, 15 Oct 2013 06:36:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381810677-4369-1-git-send-email-qiudayu@linux.vnet.ibm.com> <525CCD98.7010707@weilnetz.de> In-Reply-To: <525CCD98.7010707@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uHJiNWudlAkTTfMPxMq3g8JlGsut0Kk7c" Subject: Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Mike Qiu , qemu-devel@nongnu.org Cc: stefanha@redhat.com, aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uHJiNWudlAkTTfMPxMq3g8JlGsut0Kk7c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/14/2013 11:07 PM, Stefan Weil wrote: >=20 > Is it reasonable to get a random mac address in your guest? I don't > think so. It would no longer be possible to connect to a guest using > ssh, restart that guest and connect again with ssh. Agreed - libvirt ALWAYS passes a MAC to qemu, even if the user did not specify a MAC to libvirt, precisely because the MAC must be reproducible rather than random to avoid changing the guest ABI. I don't think this patch is needed - it's up to management to use qemu correctly. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uHJiNWudlAkTTfMPxMq3g8JlGsut0Kk7c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSXTaxAAoJEKeha0olJ0NquckH/0lIFaA0u6ZYC948QQpbZhe1 QOZjd47v2uvxabaMZk5zNKnNIdbo636BzhtCZ/IqYO4WXt6ZK9Uliw33GAoUj6ps JPBPj/ALVR1i2J7khs3nCDHOBChn/wYEOErACiEqgrL8Fp0xKvtpODoU6ieYouk4 YoqdyoEslSln+oepzLJ6C1JS/vNh3a4Eu4TAodgpeh0ljDkOLT8YPIY4AhiT220M cYamSLGyUFRJ7MRr0sqLc79Fomp08NFNE/6PvnwNrguYfKms/77i94LWSgSba0y4 tx4PG3RTitybKyOia3Iy/BhHDYlZ9XztRrUToijgJqwEba/DnG8/56izE+BzUDo= =Uz0T -----END PGP SIGNATURE----- --uHJiNWudlAkTTfMPxMq3g8JlGsut0Kk7c--