From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW61E-0000pR-P3 for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VW618-0001Ff-On for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:54:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VW618-0001FQ-ED for qemu-devel@nongnu.org; Tue, 15 Oct 2013 10:54:38 -0400 Message-ID: <525D5720.2030908@redhat.com> Date: Tue, 15 Oct 2013 16:54:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1381762577-12526-1-git-send-email-mst@redhat.com> <1381762577-12526-43-git-send-email-mst@redhat.com> <525D51C3.2050201@redhat.com> <20131015143530.GA7763@redhat.com> <525D5630.1030801@redhat.com> <20131015145450.GA7897@redhat.com> In-Reply-To: <20131015145450.GA7897@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, marcel.a@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com, Anthony Liguori , imammedo@redhat.com Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto: > > > Seemed cleaner not to. > > > > It certainly would be if we had a self-descriptive migration stream format. > > > > However, what we have is "send bytes, parse them on the destination, > > hope the format matches". Hence, anything that makes the format less > > declarative adds to the complication and complicates debugging. This is > > the same reason why I prefer a subsection for the new hotplug stuff---it > > makes the format more declarative and self-descriptive. > > I understand for the subsection but why is removing > useless bytes from there making it less descriptive? Because the same version can have multiple formats depending on a datum that is not part of the migration stream. Paolo