From: Paolo Bonzini <pbonzini@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: mst@redhat.com, qemu-stable@nongnu.org, afaerber@suse.de,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 03/12] virtio-ccw: remove vdev field
Date: Tue, 15 Oct 2013 17:59:00 +0200 [thread overview]
Message-ID: <525D6644.6050506@redhat.com> (raw)
In-Reply-To: <20131015171900.41b64b45@gondolin>
Il 15/10/2013 17:19, Cornelia Huck ha scritto:
>
>> > The vdev field is complicated to synchronize. Just access the
>> > BusState's list of children.
>> >
>> > Cc: qemu-stable@nongnu.org
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> > ---
>> > hw/s390x/virtio-ccw.c | 80 ++++++++++++++++++++++++++++-----------------------
>> > hw/s390x/virtio-ccw.h | 1 -
>> > 2 files changed, 44 insertions(+), 37 deletions(-)
>> >
>> > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
>> > index a6accdf..753b7e1 100644
>> > --- a/hw/s390x/virtio-ccw.c
>> > +++ b/hw/s390x/virtio-ccw.c
>> > @@ -230,6 +236,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
>> > hwaddr indicators;
>> > VqConfigBlock vq_config;
>> > VirtioCcwDevice *dev = sch->driver_data;
>> > + VirtIODevice *vdev = virtio_bus_get_device(&dev->bus);
> You dereference dev before it is checked against NULL. While that
> should not happen, I'd prefer virtio_ccw_get_vdev() instead.
>
Thanks, will do.
Paolo
next prev parent reply other threads:[~2013-10-15 15:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 14:52 [Qemu-devel] [PATCH v2 00/12] virtio: cleanup and fix hot-unplug Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug Paolo Bonzini
2013-10-15 15:05 ` Cornelia Huck
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 02/12] virtio-bus: remove vdev field Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 03/12] virtio-ccw: " Paolo Bonzini
2013-10-15 15:19 ` Cornelia Huck
2013-10-15 15:59 ` Paolo Bonzini [this message]
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 04/12] virtio-pci: " Paolo Bonzini
2013-10-15 15:40 ` Michael S. Tsirkin
2013-10-15 15:53 ` Paolo Bonzini
2013-10-15 16:06 ` Michael S. Tsirkin
2013-10-15 16:42 ` Paolo Bonzini
2013-10-15 20:11 ` Michael S. Tsirkin
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 05/12] virtio-bus: cleanup plug/unplug interface Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 06/12] virtio-blk: switch exit callback to VirtioDeviceClass Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 07/12] virtio-serial: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 08/12] virtio-net: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 09/12] virtio-scsi: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 10/12] virtio-balloon: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 11/12] virtio-rng: " Paolo Bonzini
2013-10-15 14:52 ` [Qemu-devel] [PATCH v2 12/12] virtio-pci: add device_unplugged callback Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525D6644.6050506@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).